Mercurial > hg
annotate tests/test-check-pylint.t @ 39232:0a5b20c107a6
repository: remove storedeltachains from ifilestorage
The ifilestorage interface was bootstrapped from requirements of
callers outside the storage implementation (revlogs). I believe we
even made some members public so they could be part of the interface!
Historically, the changegroup code was a gross offender when it
came to accessing low-level storage primitives. There are a handful
of members on the ifilestorage interface that are/were used only
for changegroup code.
With the recent refactor of changegroup code and the establishment
of a formal API on the storage interface for producing revision
deltas, the changegroup code is no longer accessing these low-level
primitives related to delta generation directly. Instead, things
are abstracted away in the storage implementation.
This means we can remove elements from the storage interface that
are no longer needed.
We start with "storedeltachains."
We remove it from the interface. Then we make it a private
attribute and update all references.
.. api:: storedeltachains has been dropped from ifilestorage interface
.. api:: storedeltachains on revlog classes is now _storedeltachains
Differential Revision: https://phab.mercurial-scm.org/D4227
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Thu, 09 Aug 2018 16:11:24 -0700 |
parents | 6ae62d62c3f6 |
children | c7899dd29800 |
rev | line source |
---|---|
31413
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
1 #require test-repo pylint hg10 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
2 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
3 Run pylint for known rules we care about. |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
4 ----------------------------------------- |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
5 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
6 There should be no recorded failures; fix the codebase before introducing a |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
7 new check. |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
8 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
9 Current checks: |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
10 - W0102: no mutable default argument |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
11 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
12 $ touch $TESTTMP/fakerc |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
13 $ pylint --rcfile=$TESTTMP/fakerc --disable=all \ |
35630
6061e54ff81d
pylint: add a check for multiple statement on a single line
Boris Feld <boris.feld@octobus.net>
parents:
35627
diff
changeset
|
14 > --enable=W0102,C0321 \ |
35627
882998f08c3c
pylint: split command line argument on multiple lines
Boris Feld <boris.feld@octobus.net>
parents:
34395
diff
changeset
|
15 > --reports=no \ |
34395
41401f502c83
tests: disable lints on mercurial/thirdparty
Siddharth Agarwal <sid0@fb.com>
parents:
32421
diff
changeset
|
16 > --ignore=thirdparty \ |
38180
6ae62d62c3f6
tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents:
35630
diff
changeset
|
17 > mercurial hgdemandimport hgext hgext3rd | sed 's/\r$//' |
6ae62d62c3f6
tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents:
35630
diff
changeset
|
18 Using config file *fakerc (glob) (?) |
31839
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
19 (?) |
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
20 ------------------------------------ (?) |
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
21 Your code has been rated at 10.00/10 (?) |
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
22 (?) |