annotate tests/test-merge2.t @ 42619:20d0e59be79b

tests: show the files fields of changelogs for many merges I don't think there's coverage for many of the subtle cases, and I found it hard to understand what the code is doing by reading it. The test takes 40s to run on a laptop, or 9s with --chg. I have yet to find a description of what the files field is supposed to be for merges. I thought it could be one of: 1. the files added/modified/removed relative to p1 (wouldn't seem useful, but `hg diff -c -r mergerev` has this behavior) 2. the files with filelog nodes not in either parent (i.e., what is needed to create a bundle out of a commit) 3. the files added/removed/modified files by merge itself [1] It's clearly not 1, because file contents merges are symmetric. It's clearly not 2 because removed files and exec bit changes are listed. It's also not 3 but I think it's intended to be 3 and the differences are bugs. Assuming 3, the test shows that, for merges, the list of files both overapproximates and underapproximates. All the cases involve file changes not in the filelog but in the manifest (existence of file at revision, exec bit and file vs symlink). I didn't look at all underapproximations, but they looked minor. The two overapproximations are problematic though because they both cause potentially long lists of files when merging cleanly. [1] even what it means for the merge commit itself to change a file is not completely trivial. A file in the merge being the same as in one of the parent is too lax as it would consider that merges change nothing when they revert all the changes done on one side. The criteria used in the test and in the next commit for "merge didn't touch a file" is: - the parents and the merge all have the same file - or, one parent didn't touch the file and the other parent contains the same file as the merge Differential Revision: https://phab.mercurial-scm.org/D6612
author Valentin Gatien-Baron <valentin.gatienbaron@gmail.com>
date Tue, 02 Jul 2019 12:55:51 -0400
parents f2719b387380
children 1850066f9e36
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13956
ffb5c09ba822 tests: remove redundant mkdir
Martin Geisler <mg@lazybytes.net>
parents: 12156
diff changeset
1 $ hg init t
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
2 $ cd t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
3 $ echo This is file a1 > a
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
4 $ hg add a
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
5 $ hg commit -m "commit #0"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
6 $ echo This is file b1 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
7 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
8 $ hg commit -m "commit #1"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
9 $ rm b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
10 $ hg update 0
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
11 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
12 $ echo This is file b2 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
13 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
14 $ hg commit -m "commit #2"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
15 created new head
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
16 $ cd ..; rm -r t
409
feadc9697b43 Pick up tests from previous patch
mpm@selenic.com
parents:
diff changeset
17
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
18 $ mkdir t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
19 $ cd t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
20 $ hg init
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
21 $ echo This is file a1 > a
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
22 $ hg add a
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
23 $ hg commit -m "commit #0"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
24 $ echo This is file b1 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
25 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
26 $ hg commit -m "commit #1"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
27 $ rm b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
28 $ hg update 0
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
29 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
30 $ echo This is file b2 > b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
31 $ hg commit -A -m "commit #2"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
32 adding b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
33 created new head
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
34 $ cd ..; rm -r t
409
feadc9697b43 Pick up tests from previous patch
mpm@selenic.com
parents:
diff changeset
35
13956
ffb5c09ba822 tests: remove redundant mkdir
Martin Geisler <mg@lazybytes.net>
parents: 12156
diff changeset
36 $ hg init t
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
37 $ cd t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
38 $ echo This is file a1 > a
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
39 $ hg add a
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
40 $ hg commit -m "commit #0"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
41 $ echo This is file b1 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
42 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
43 $ hg commit -m "commit #1"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
44 $ rm b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
45 $ hg remove b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
46 $ hg update 0
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
47 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
48 $ echo This is file b2 > b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
49 $ hg commit -A -m "commit #2"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
50 adding b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
51 created new head
16913
f2719b387380 tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents: 13956
diff changeset
52
f2719b387380 tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents: 13956
diff changeset
53 $ cd ..