Mercurial > hg
annotate tests/test-check-code-hg.t @ 23976:344939126579 stable
largefiles: don't interfere with logging normal files
The previous code was adding standin files to the matcher's file list when
neither the standin file nor the original existed in the context. Somehow, this
was confusing the logging code into behaving differently from when the extension
wasn't loaded.
It seems that this was an attempt to support naming a directory that only
contains largefiles, as a test fails if the else clause is dropped entirely.
Therefore, only append the "standin" if it is a directory. This was found by
running the test suite with --config extensions.largefiles=.
The first added test used to log an additional cset that wasn't logged normally.
The only relation it had to file 'a' is that 'a' was the source of a move, but
it isn't clear why having '.hglf/a' in the list causes this change:
@@ -47,6 +47,11 @@
Make sure largefiles doesn't interfere with logging a regular file
$ hg log a --config extensions.largefiles=
+ changeset: 3:2ca5ba701980
+ user: test
+ date: Thu Jan 01 00:00:04 1970 +0000
+ summary: d
+
changeset: 0:9161b9aeaf16
user: test
date: Thu Jan 01 00:00:01 1970 +0000
The second added test used to complain about a file not being in the parent
revision:
@@ -1638,10 +1643,8 @@
Ensure that largefiles doesn't intefere with following a normal file
$ hg --config extensions.largefiles= log -f d -T '{desc}' -G
- @ c
- |
- o a
-
+ abort: cannot follow file not in parent revision: ".hglf/d"
+ [255]
$ hg log -f d/a -T '{desc}' -G
@ c
|
Note that there is still something fishy with the largefiles code, because when
using a glob pattern like this:
$ hg log 'glob:sub/*'
the pattern list would contain '.hglf/glob:sub/*'. None of the tests show this
(this test lives in test-largefiles.t at 1349), it was just something that I
noticed when the code was loaded up with print statements.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Fri, 30 Jan 2015 20:44:11 -0500 |
parents | 8fb6844a4ff1 |
children |
rev | line source |
---|---|
22047
8fb6844a4ff1
tests: change some #ifs to #requires
Matt Mackall <mpm@selenic.com>
parents:
21225
diff
changeset
|
1 #require test-repo |
21223
c35c027f5f43
test-check-code-hg: use test-repo check
Matt Mackall <mpm@selenic.com>
parents:
20239
diff
changeset
|
2 |
15557
7bb5ed61b74c
tests: convert test-check-code-hg.py to .t
Mads Kiilerich <mads@kiilerich.com>
parents:
11771
diff
changeset
|
3 $ check_code="$TESTDIR"/../contrib/check-code.py |
7bb5ed61b74c
tests: convert test-check-code-hg.py to .t
Mads Kiilerich <mads@kiilerich.com>
parents:
11771
diff
changeset
|
4 $ cd "$TESTDIR"/.. |
15558
c6b600d2348c
tests: run check-code with warnings and maintain a whitelist
Mads Kiilerich <mads@kiilerich.com>
parents:
15557
diff
changeset
|
5 |
19384
96fd9af75834
tests: check-code all python files in one run
Simon Heimberg <simohe@besonet.ch>
parents:
19321
diff
changeset
|
6 New errors are not allowed. Warnings are strongly discouraged. |
20239
16b5f498f49c
check-code: always report when a file is skipped by "no-check-code"
Simon Heimberg <simohe@besonet.ch>
parents:
19495
diff
changeset
|
7 (The writing "no-che?k-code" is for not skipping this file when checking.) |
19384
96fd9af75834
tests: check-code all python files in one run
Simon Heimberg <simohe@besonet.ch>
parents:
19321
diff
changeset
|
8 |
21225
c58aa73bf0b9
test-check-code-hg: use locate instead of manifest
Matt Mackall <mpm@selenic.com>
parents:
21224
diff
changeset
|
9 $ hg locate | sed 's-\\-/-g' | |
19495
9aee3d014394
tests: test-check-code-hg.t works for all files to check
Simon Heimberg <simohe@besonet.ch>
parents:
19386
diff
changeset
|
10 > xargs "$check_code" --warnings --per-file=0 || false |
20239
16b5f498f49c
check-code: always report when a file is skipped by "no-check-code"
Simon Heimberg <simohe@besonet.ch>
parents:
19495
diff
changeset
|
11 Skipping hgext/zeroconf/Zeroconf.py it has no-che?k-code (glob) |
16b5f498f49c
check-code: always report when a file is skipped by "no-check-code"
Simon Heimberg <simohe@besonet.ch>
parents:
19495
diff
changeset
|
12 Skipping i18n/polib.py it has no-che?k-code (glob) |
16b5f498f49c
check-code: always report when a file is skipped by "no-check-code"
Simon Heimberg <simohe@besonet.ch>
parents:
19495
diff
changeset
|
13 Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob) |
16b5f498f49c
check-code: always report when a file is skipped by "no-check-code"
Simon Heimberg <simohe@besonet.ch>
parents:
19495
diff
changeset
|
14 Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob) |
16b5f498f49c
check-code: always report when a file is skipped by "no-check-code"
Simon Heimberg <simohe@besonet.ch>
parents:
19495
diff
changeset
|
15 Skipping mercurial/httpclient/socketutil.py it has no-che?k-code (glob) |