Mercurial > hg
annotate tests/test-diff-hashes.t @ 20742:3681de20b0a7
parsers: fail fast if Python has wrong minor version (issue4110)
This change causes an informative ImportError to be raised when importing
the parsers extension module if the minor version of the currently-running
Python interpreter doesn't match that of the Python used when compiling
the extension module.
This change also exposes a parsers.versionerrortext constant in the
C implementation of the module. Its presence can be used to determine
whether this behavior is present in a version of the module. The value
of the constant is the leading text of the ImportError raised and is set
to "Python minor version mismatch".
Here is an example of what the new error looks like:
Traceback (most recent call last):
File "test.py", line 1, in <module>
import mercurial.parsers
ImportError: Python minor version mismatch: The Mercurial extension
modules were compiled with Python 2.7.6, but Mercurial is currently using
Python with sys.hexversion=33883888: Python 2.5.6
(r256:88840, Nov 18 2012, 05:37:10)
[GCC 4.2.1 Compatible Apple Clang 4.1 ((tags/Apple/clang-421.11.66))]
at: /opt/local/Library/Frameworks/Python.framework/Versions/2.5/Resources/
Python.app/Contents/MacOS/Python
The reason for raising an error in this scenario is that Python's C API
is known not to be compatible from minor version to minor version, even
if sys.api_version is the same. See for example this Python bug report
about incompatibilities between 2.5 and 2.6+:
http://bugs.python.org/issue8118
These incompatibilities can cause Mercurial to break in mysterious,
unforeseen ways. For example, when Mercurial compiled with Python 2.7 was
run with 2.5, the following crash occurred when running "hg status":
http://bz.selenic.com/show_bug.cgi?id=4110
After this crash was fixed, running with Python 2.5 no longer crashes, but
the following puzzling behavior still occurs:
$ hg status
...
File ".../mercurial/changelog.py", line 123, in __init__
revlog.revlog.__init__(self, opener, "00changelog.i")
File ".../mercurial/revlog.py", line 251, in __init__
d = self._io.parseindex(i, self._inline)
File ".../mercurial/revlog.py", line 158, in parseindex
index, cache = parsers.parse_index2(data, inline)
TypeError: data is not a string
which can be reproduced more simply with:
import mercurial.parsers as parsers
parsers.parse_index2("", True)
Both the crash and the TypeError occurred because the Python C API's
PyString_Check() returns the wrong value when the C header files from
Python 2.7 are run with Python 2.5. This is an example of an
incompatibility of the sort mentioned in the Python bug report above.
Failing fast with an informative error message results in a better user
experience in cases like the above. The information in the ImportError
also simplifies troubleshooting for those on Mercurial mailing lists, the
bug tracker, etc.
This patch only adds the version check to parsers.c, which is sufficient
to affect command-line commands like "hg status" and "hg summary".
An idea for a future improvement is to move the version-checking C code
to a more central location, and have it run when importing all
Mercurial extension modules and not just parsers.c.
author | Chris Jerdonek <chris.jerdonek@gmail.com> |
---|---|
date | Wed, 04 Dec 2013 20:38:27 -0800 |
parents | f2719b387380 |
children | 251332dbf33d |
rev | line source |
---|---|
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
1 $ hg init a |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
2 $ cd a |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
3 |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
4 $ hg diff inexistent1 inexistent2 |
15521
117f9190c1ba
tests: hide 'No such file or directory' messages
Mads Kiilerich <mads@kiilerich.com>
parents:
12156
diff
changeset
|
5 inexistent1: * (glob) |
117f9190c1ba
tests: hide 'No such file or directory' messages
Mads Kiilerich <mads@kiilerich.com>
parents:
12156
diff
changeset
|
6 inexistent2: * (glob) |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
7 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
8 $ echo bar > foo |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
9 $ hg add foo |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
10 $ hg ci -m 'add foo' |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
11 |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
12 $ echo foobar > foo |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
13 $ hg ci -m 'change foo' |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
14 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
15 $ hg --quiet diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
16 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
17 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
18 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
19 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
20 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
21 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
22 $ hg diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
23 diff -r a99fb63adac3 -r 9b8568d3af2f foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
24 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
25 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
26 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
27 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
28 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
29 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
30 $ hg --verbose diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
31 diff -r a99fb63adac3 -r 9b8568d3af2f foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
32 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
33 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
34 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
35 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
36 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
37 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
38 $ hg --debug diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
39 diff -r a99fb63adac3f31816a22f665bc3b7a7655b30f4 -r 9b8568d3af2f1749445eef03aede868a6f39f210 foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
40 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
41 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
42 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
43 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
44 +foobar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
45 |
16913
f2719b387380
tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents:
15521
diff
changeset
|
46 $ cd .. |