Mercurial > hg
annotate tests/test-check-shbang.t @ 49603:3eda36e9b3d6 stable
matcher: fix issues regex flag contained in pattern (issue6759)
Python 3.11 is now enforcing that flag must be at the beginning of the regex
This creates a serious regression for people using Python 3.11 with an hgignore
using flag in a "relre" pattern.
We now detect any flags in such pattern and "prepend" our ".*" pattern after them.
In addition, we now insert the flag in the regexp to only affect the pattern we
are rewriting. Otherwise, the regex built from the combined pattern would these
flags in the middle of it anyway.
As a side effect of this last change, we fix a bug… before this change regex
flag in a pattern would affect all combined patterns. That was bad and is not
longer the case.
The Rust code needs to be updated to fix that very bug, but we will do it in
another changeset.
author | Pierre-Yves David <pierre-yves.david@octobus.net> |
---|---|
date | Wed, 16 Nov 2022 13:05:01 +0100 |
parents | 2d8d4e08c493 |
children | 37de1a154472 |
rev | line source |
---|---|
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
1 #require test-repo |
27569 | 2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
28879
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
27569 | 4 $ cd "`dirname "$TESTDIR"`" |
5 | |
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
6 look for python scripts that do not use /usr/bin/env |
27569 | 7 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
8 $ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t' |
27569 | 9 [1] |
10 | |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
11 In tests, enforce $PYTHON and *not* /usr/bin/env python or similar: |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
12 $ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \ |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
13 > -X tests/test-check-execute.t \ |
43692
2d8d4e08c493
tests: verify that Python scripts are blackened
Gregory Szorc <gregory.szorc@gmail.com>
parents:
33204
diff
changeset
|
14 > -X tests/test-check-format.t \ |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
15 > -X tests/test-check-module-imports.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
16 > -X tests/test-check-pyflakes.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
17 > -X tests/test-check-shbang.t |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
18 [1] |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
19 |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
20 The above exclusions are because they're looking for files that |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
21 contain Python but don't end in .py - please avoid adding more. |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
22 |
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
23 look for shell scripts that do not use /bin/sh |
27569 | 24 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
25 $ testrepohg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")' |
27569 | 26 [1] |