Mercurial > hg
annotate tests/test-check-shbang.t @ 41710:4028897dfa05
url: always use str for proxy configuration
Previously, proxies didn't work on Python 3 for various reasons.
First, the keys to the "proxies" dict are fed into a
`setattr(self, "%s_open", ...)` call and passing bytestrings
results in setting an oddly named attribute due to the b''
in %s formatting. This resulted in "http_open" and "https_open"
not being properly overridden and proxies not being used.
Second, the standard library was expecting proxy URLs to be
str. And various operations (including our custom code in
url.py) would fail to account for the str/bytes mismatch.
This commit normalizes everything to str and adjusts our
proxy code in url.py to account for the presence of str
on Python 3.
Differential Revision: https://phab.mercurial-scm.org/D5952
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Fri, 15 Feb 2019 13:16:07 -0800 |
parents | ddd65b4f3ae6 |
children | 2d8d4e08c493 |
rev | line source |
---|---|
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
1 #require test-repo |
27569 | 2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
28879
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
27569 | 4 $ cd "`dirname "$TESTDIR"`" |
5 | |
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
6 look for python scripts that do not use /usr/bin/env |
27569 | 7 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
8 $ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t' |
27569 | 9 [1] |
10 | |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
11 In tests, enforce $PYTHON and *not* /usr/bin/env python or similar: |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
12 $ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \ |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
13 > -X tests/test-check-execute.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
14 > -X tests/test-check-module-imports.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
15 > -X tests/test-check-pyflakes.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
16 > -X tests/test-check-shbang.t |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
17 [1] |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
18 |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
19 The above exclusions are because they're looking for files that |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
20 contain Python but don't end in .py - please avoid adding more. |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
21 |
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
22 look for shell scripts that do not use /bin/sh |
27569 | 23 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
24 $ testrepohg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")' |
27569 | 25 [1] |