Mercurial > hg
annotate tests/test-no-symlinks.t @ 47866:4162f6b40f2c stable
windows: degrade to py2 behavior when reading a non-symlink as a symlink
While waiting for the push to hg-committed in WSL to complete, I ran a
`phabimport` from Windows and got this traceback:
$ hg phabimport 11313
** Unknown exception encountered with possibly-broken third-party extension "mercurial_keyring" (version N/A)
** which supports versions unknown of Mercurial.
** Please disable "mercurial_keyring" and try your action again.
** If that fixes the bug please report it to https://foss.heptapod.net/mercurial/mercurial_keyring/issues
** Python 3.9.5 (default, May 6 2021, 17:29:31) [MSC v.1928 64 bit (AMD64)]
** Mercurial Distributed SCM (version 5.9rc1+hg32.0e2f5733563d)
** Extensions loaded: absorb, blackbox, evolve 10.3.3, extdiff, fastannotate, fix, mercurial_keyring, mq, phabblocker 20210126, phabricator, rebase, show, strip, topic 0.22.3
Traceback (most recent call last):
File "mercurial.lock", line 279, in _trylock
File "mercurial.vfs", line 202, in makelock
File "mercurial.util", line 2147, in makelock
FileExistsError: [WinError 183] Cannot create a file when that file already exists: b'hp-omen:78348' -> b'C:\\Users\\Matt\\hg/.hg/store/lock'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 24, in <module>
File "mercurial.dispatch", line 144, in run
File "mercurial.dispatch", line 250, in dispatch
File "mercurial.dispatch", line 294, in _rundispatch
File "mercurial.dispatch", line 470, in _runcatch
File "mercurial.dispatch", line 480, in _callcatch
File "mercurial.scmutil", line 153, in callcatch
File "mercurial.dispatch", line 460, in _runcatchfunc
File "mercurial.dispatch", line 1273, in _dispatch
File "mercurial.dispatch", line 918, in runcommand
File "mercurial.dispatch", line 1285, in _runcommand
File "mercurial.dispatch", line 1271, in <lambda>
File "mercurial.util", line 1886, in check
File "mercurial.util", line 1886, in check
File "hgext.mq", line 4239, in mqcommand
File "mercurial.util", line 1886, in check
File "mercurial.util", line 1886, in check
File "hgext.phabricator", line 314, in inner
File "hgext.phabricator", line 2222, in phabimport
File "hgext.phabricator", line 2123, in readpatch
File "hgext.phabricator", line 2199, in _write
File "mercurial.localrepo", line 2956, in lock
File "mercurial.localrepo", line 2918, in _lock
File "mercurial.lock", line 152, in trylock
File "mercurial.lock", line 283, in _trylock
File "mercurial.lock", line 314, in _readlock
File "mercurial.vfs", line 221, in readlock
File "mercurial.util", line 2163, in readlock
File "mercurial.windows", line 619, in readlink
ValueError: not a symbolic link
Both exceptions look accurate (the file exists, and the Windows side can't read
WSL side symlinks). I didn't try to reproduce this entirely within the Windows
side, but we can do better than a cryptic stacktrace. With this change, the
same scenario results in this abort:
abort: C:\Users\Matt\hg/.hg/store/lock: The file cannot be accessed by the system
When both the `push` and `phabimport` are done on the Windows side, it prints a
message about waiting for the lock, and successfully applies the patch after the
push completes.
I'm not sure if there's enough info to be able to convert the abort into the
wait scenario. As it stands now, we don't support symlinks on Windows, which
requires either a UAC Administrator level process or an opt-in in developer
mode, and there are several places where the new symlink on Windows support in
py3 was explicitly disabled in order to get tests to pass quicker.
Differential Revision: https://phab.mercurial-scm.org/D11333
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sun, 22 Aug 2021 17:59:21 -0400 |
parents | 0612e4c6fda0 |
children |
rev | line source |
---|---|
22046
7a9cbb315d84
tests: replace exit 80 with #require
Matt Mackall <mpm@selenic.com>
parents:
14116
diff
changeset
|
1 #require no-symlink |
5085
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
2 |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
3 # The following script was used to create the bundle: |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
4 # |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
5 # hg init symlinks |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
6 # cd symlinks |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
7 # echo a > a |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
8 # mkdir d |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
9 # echo b > d/b |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
10 # ln -s a a.lnk |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
11 # ln -s d/b d/b.lnk |
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
12 # hg ci -Am t |
5089
9b5ae133bd5a
test-no-symlinks: rename .bundle into .hg for consistency.
Patrick Mezard <pmezard@gmail.com>
parents:
5085
diff
changeset
|
13 # hg bundle --base null ../test-no-symlinks.hg |
5085
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
14 |
12917
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
15 Extract a symlink on a platform not supporting them |
5085
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
16 |
12917
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
17 $ hg init t |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
18 $ cd t |
14116
cd3032437064
tests: move test bundles in a bundles/ subdirectory
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
12917
diff
changeset
|
19 $ hg pull -q "$TESTDIR/bundles/test-no-symlinks.hg" |
12917
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
20 $ hg update |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
21 4 files updated, 0 files merged, 0 files removed, 0 files unresolved |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
22 $ cat a.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
23 a |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
24 $ cat d/b.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
25 d/b |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
26 |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
27 Copy a symlink and move another |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
28 |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
29 $ hg copy a.lnk d/a2.lnk |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
30 $ hg mv d/b.lnk b2.lnk |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
31 $ hg ci -Am copy |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
32 $ cat d/a2.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
33 a |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
34 $ cat b2.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
35 d/b |
5085
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
36 |
12917
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
37 Bundle and extract again |
5085
dcfd75502b82
Test symlink handling on platform not supporting them
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
38 |
12917
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
39 $ hg bundle --base null ../symlinks.hg |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
40 2 changesets found |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
41 $ cd .. |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
42 $ hg init t2 |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
43 $ cd t2 |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
44 $ hg pull ../symlinks.hg |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
45 pulling from ../symlinks.hg |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
46 requesting all changes |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
47 adding changesets |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
48 adding manifests |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
49 adding file changes |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
50 added 2 changesets with 6 changes to 6 files |
39520
0612e4c6fda0
tests: stabilize test-no-symlink
Matt Harbison <matt_harbison@yahoo.com>
parents:
34814
diff
changeset
|
51 new changesets d326ae2d01ee:71d85cf3ba90 (2 drafts) |
12917
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
52 (run 'hg update' to get a working copy) |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
53 $ hg update |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
54 5 files updated, 0 files merged, 0 files removed, 0 files unresolved |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
55 $ cat a.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
56 a |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
57 $ cat d/a2.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
58 a |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
59 $ cat b2.lnk && echo |
a419cb2395d5
tests: unify test-no-symlinks
Patrick Mezard <pmezard@gmail.com>
parents:
5091
diff
changeset
|
60 d/b |