contrib/wix/defines.wxi
author Matt Harbison <matt_harbison@yahoo.com>
Tue, 04 Nov 2014 12:46:00 -0500
changeset 23347 49cdf51cbc6c
parent 13042 bd9bc4123920
permissions -rw-r--r--
run-tests: include quotes in the HGEDITOR value when storing sys.executable This fixes test-install.t on Windows that broke in 2122b82b6987 when shlex.split() was added to the debuginstall command: @@ -7,8 +7,11 @@ checking installed modules (*mercurial)... (glob) checking templates (*mercurial?templates)... (glob) checking commit editor... + Can't find editor 'c:\Python27\python.exe -c "(omitted)"' in PATH + (specify a commit editor in your configuration file) checking username... - no problems detected + 1 problems detected, please check your install! + [1] What happens is that shlex.split() on Windows turns this: c:\Python27\python.exe -c "import sys; sys.exit(0)" into this: ['c:Python27python.exe', '-c', 'import sys; sys.exit(0)'] While technically a regression, most programs on Windows live in some flavor of 'Program Files', and therefore the environment variable needs to contain quotes anyway to handle the space. This wasn't handled prior to the shlex() change, because it tested the whole environment variable to see if it was an executable, or split on the first space and tested again.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
13042
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     1
<Include>
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     2
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     3
  <?if $(var.Platform) = "x64" ?>
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     4
    <?define IsX64 = yes ?>
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     5
  <?else?>
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     6
    <?define IsX64 = no ?>
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     7
  <?endif?>
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     8
bd9bc4123920 wix: add support for x64 native MSI packages
Steve Borho <steve@borho.org>
parents:
diff changeset
     9
</Include>