Mercurial > hg
annotate tests/helper-runtests.sh @ 34107:4f60720cf0df
blackbox: fix rotation with chg
The added test will show:
$ $PYTHON showsize.py .hg/blackbox*
.hg/blackbox.log: < 500
.hg/blackbox.log.1: < 500
.hg/blackbox.log.2: < 500
.hg/blackbox.log.3: < 500
.hg/blackbox.log.4: < 500
.hg/blackbox.log.5: >= 500
with previous code.
The issue is caused by blackbox caching file objects *by path*, and the
rotation size check could run on a wrong file object (i.e. it should check
"blackbox.log", but `filehandles["blackbox.log"]` contains a file object
that has been renamed to "blackbox.log.5").
This patch removes the "filehandlers" global cache added by 45313f5a3a8c to
solve the issue.
I think the original patch was trying to make different ui objects use a same
file object if their blackbox.log path is the same. In theory it could also
be problematic in the rotation case. Anyway, that should become unnecessary
after D650.
Differential Revision: https://phab.mercurial-scm.org/D648
author | Jun Wu <quark@fb.com> |
---|---|
date | Wed, 06 Sep 2017 19:27:30 -0700 |
parents | 054bcdad6042 |
children |
rev | line source |
---|---|
29220
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
1 # |
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
2 # Avoid interference from actual test env: |
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
3 |
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
4 unset HGTEST_JOBS |
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
5 unset HGTEST_TIMEOUT |
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
6 unset HGTEST_PORT |
054bcdad6042
tests: refactor run-tests helpers
timeless <timeless@mozdev.org>
parents:
diff
changeset
|
7 unset HGTEST_SHELL |