Mercurial Mercurial > hg / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
contrib/clang-format-blacklist
author Gregory Szorc <gregory.szorc@gmail.com>
Sat, 20 Jan 2018 22:55:42 -0800
changeset 35793 4fb2bb61597c
parent 34862 d92dc725223b
child 35959 9724f54923ec
permissions -rw-r--r--
bundle2: increase payload part chunk size to 32kb Bundle2 payload parts are framed chunks. Esentially, we obtain data in equal size chunks of size `preferedchunksize` and emit those to a generator. That generator is fed into a compressor (which can be the no-op compressor, which just re-emits the generator). And the output from the compressor likely goes to a file descriptor or socket. What this means is that small chunk sizes create more Python objects and Python function calls than larger chunk sizes. And as we know, Python object and function call overhead in performance sensitive code matters (at least with CPython). This commit increases the bundle2 part payload chunk size from 4k to 32k. Practically speaking, this means that the chunks we feed into a compressor (implemented in C code) or feed directly into a file handle or socket write() are larger. It's possible the chunks might be larger than what the receiver can handle in one logical operation. But at that point, we're in C code, which is much more efficient at dealing with splitting up the chunk and making multiple function calls than Python is. A downside to larger chunks is that the receiver has to wait for that much data to arrive (either raw or from a decompressor) before it can process the chunk. But 32kb still feels like a small buffer to have to wait for. And in many cases, the client will convert from 8 read(4096) to 1 read(32768). That's happening in Python land. So we cut down on the number of Python objects and function calls, making the client faster as well. I don't think there are any significant concerns to increasing the payload chunk size to 32kb. The impact of this change on performance significant. Using `curl` to obtain a stream clone bundle2 payload from a server on localhost serving the mozilla-unified repository: before: 20.78 user; 7.71 system; 80.5 MB/s after: 13.90 user; 3.51 system; 132 MB/s legacy: 9.72 user; 8.16 system; 132 MB/s bundle2 stream clone generation is still more resource intensive than legacy stream clone (that's likely because of the use of a util.chunkbuffer). But the throughput is the same. We might be in territory we're this is effectively a benchmark of the networking stack or Python's syscall throughput. From the client perspective, `hg clone -U --stream`: before: 33.50 user; 7.95 system; 53.3 MB/s after: 22.82 user; 7.33 system; 72.7 MB/s legacy: 29.96 user; 7.94 system; 58.0 MB/s And for `hg clone --stream` with a working directory update of ~230k files: after: 119.55 user; 26.47 system; 0:57.08 wall legacy: 126.98 user; 26.94 system; 1:05.56 wall So, it appears that bundle2's stream clone is now definitively faster than legacy stream clone! Differential Revision: https://phab.mercurial-scm.org/D1932
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
34834
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     1
 
# Files that just need to be migrated to the formatter.
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     2
 
# Do not add new files here!
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     3
 
contrib/chg/chg.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     4
 
contrib/chg/hgclient.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     5
 
contrib/chg/hgclient.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     6
 
contrib/chg/procutil.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     7
 
contrib/chg/procutil.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     8
 
contrib/chg/util.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
     9
 
contrib/chg/util.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    10
 
contrib/hgsh/hgsh.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    11
 
mercurial/cext/base85.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    12
 
mercurial/cext/bdiff.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    13
 
mercurial/cext/charencode.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    14
 
mercurial/cext/charencode.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    15
 
mercurial/cext/diffhelpers.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    16
 
mercurial/cext/dirs.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    17
 
mercurial/cext/manifest.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    18
 
mercurial/cext/mpatch.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    19
 
mercurial/cext/osutil.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    20
 
mercurial/cext/pathencode.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    21
 
mercurial/cext/revlog.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    22
 
# Vendored code that we should never format:
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    23
 
contrib/python-zstandard/c-ext/bufferutil.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    24
 
contrib/python-zstandard/c-ext/compressiondict.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    25
 
contrib/python-zstandard/c-ext/compressionparams.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    26
 
contrib/python-zstandard/c-ext/compressionwriter.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    27
 
contrib/python-zstandard/c-ext/compressobj.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    28
 
contrib/python-zstandard/c-ext/compressor.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    29
 
contrib/python-zstandard/c-ext/compressoriterator.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    30
 
contrib/python-zstandard/c-ext/constants.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    31
 
contrib/python-zstandard/c-ext/decompressionwriter.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    32
 
contrib/python-zstandard/c-ext/decompressobj.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    33
 
contrib/python-zstandard/c-ext/decompressor.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    34
 
contrib/python-zstandard/c-ext/decompressoriterator.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    35
 
contrib/python-zstandard/c-ext/frameparams.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    36
 
contrib/python-zstandard/c-ext/python-zstandard.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    37
 
contrib/python-zstandard/zstd.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    38
 
contrib/python-zstandard/zstd/common/bitstream.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    39
 
contrib/python-zstandard/zstd/common/entropy_common.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    40
 
contrib/python-zstandard/zstd/common/error_private.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    41
 
contrib/python-zstandard/zstd/common/error_private.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    42
 
contrib/python-zstandard/zstd/common/fse.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    43
 
contrib/python-zstandard/zstd/common/fse_decompress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    44
 
contrib/python-zstandard/zstd/common/huf.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    45
 
contrib/python-zstandard/zstd/common/mem.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    46
 
contrib/python-zstandard/zstd/common/pool.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    47
 
contrib/python-zstandard/zstd/common/pool.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    48
 
contrib/python-zstandard/zstd/common/threading.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    49
 
contrib/python-zstandard/zstd/common/threading.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    50
 
contrib/python-zstandard/zstd/common/xxhash.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    51
 
contrib/python-zstandard/zstd/common/xxhash.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    52
 
contrib/python-zstandard/zstd/common/zstd_common.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    53
 
contrib/python-zstandard/zstd/common/zstd_errors.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    54
 
contrib/python-zstandard/zstd/common/zstd_internal.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    55
 
contrib/python-zstandard/zstd/compress/fse_compress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    56
 
contrib/python-zstandard/zstd/compress/huf_compress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    57
 
contrib/python-zstandard/zstd/compress/zstd_compress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    58
 
contrib/python-zstandard/zstd/compress/zstd_opt.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    59
 
contrib/python-zstandard/zstd/compress/zstdmt_compress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    60
 
contrib/python-zstandard/zstd/compress/zstdmt_compress.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    61
 
contrib/python-zstandard/zstd/decompress/huf_decompress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    62
 
contrib/python-zstandard/zstd/decompress/zstd_decompress.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    63
 
contrib/python-zstandard/zstd/dictBuilder/cover.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    64
 
contrib/python-zstandard/zstd/dictBuilder/divsufsort.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    65
 
contrib/python-zstandard/zstd/dictBuilder/divsufsort.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    66
 
contrib/python-zstandard/zstd/dictBuilder/zdict.c
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    67
 
contrib/python-zstandard/zstd/dictBuilder/zdict.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    68
 
contrib/python-zstandard/zstd/zstd.h
2e8477059d4f test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff changeset 
    69
 
hgext/fsmonitor/pywatchman/bser.c
Mercurial