Mercurial > hg
annotate tests/test-diff-hashes.t @ 35793:4fb2bb61597c
bundle2: increase payload part chunk size to 32kb
Bundle2 payload parts are framed chunks. Esentially, we obtain
data in equal size chunks of size `preferedchunksize` and emit those
to a generator. That generator is fed into a compressor (which can
be the no-op compressor, which just re-emits the generator). And
the output from the compressor likely goes to a file descriptor
or socket.
What this means is that small chunk sizes create more Python objects
and Python function calls than larger chunk sizes. And as we know,
Python object and function call overhead in performance sensitive
code matters (at least with CPython).
This commit increases the bundle2 part payload chunk size from 4k
to 32k. Practically speaking, this means that the chunks we feed
into a compressor (implemented in C code) or feed directly into a
file handle or socket write() are larger. It's possible the chunks
might be larger than what the receiver can handle in one logical
operation. But at that point, we're in C code, which is much more
efficient at dealing with splitting up the chunk and making multiple
function calls than Python is.
A downside to larger chunks is that the receiver has to wait for that
much data to arrive (either raw or from a decompressor) before it
can process the chunk. But 32kb still feels like a small buffer to
have to wait for. And in many cases, the client will convert from
8 read(4096) to 1 read(32768). That's happening in Python land. So
we cut down on the number of Python objects and function calls,
making the client faster as well. I don't think there are any
significant concerns to increasing the payload chunk size to 32kb.
The impact of this change on performance significant. Using `curl`
to obtain a stream clone bundle2 payload from a server on localhost
serving the mozilla-unified repository:
before: 20.78 user; 7.71 system; 80.5 MB/s
after: 13.90 user; 3.51 system; 132 MB/s
legacy: 9.72 user; 8.16 system; 132 MB/s
bundle2 stream clone generation is still more resource intensive than
legacy stream clone (that's likely because of the use of a
util.chunkbuffer). But the throughput is the same. We might
be in territory we're this is effectively a benchmark of the
networking stack or Python's syscall throughput.
From the client perspective, `hg clone -U --stream`:
before: 33.50 user; 7.95 system; 53.3 MB/s
after: 22.82 user; 7.33 system; 72.7 MB/s
legacy: 29.96 user; 7.94 system; 58.0 MB/s
And for `hg clone --stream` with a working directory update of
~230k files:
after: 119.55 user; 26.47 system; 0:57.08 wall
legacy: 126.98 user; 26.94 system; 1:05.56 wall
So, it appears that bundle2's stream clone is now definitively faster
than legacy stream clone!
Differential Revision: https://phab.mercurial-scm.org/D1932
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Sat, 20 Jan 2018 22:55:42 -0800 |
parents | f2719b387380 |
children | 251332dbf33d |
rev | line source |
---|---|
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
1 $ hg init a |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
2 $ cd a |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
3 |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
4 $ hg diff inexistent1 inexistent2 |
15521
117f9190c1ba
tests: hide 'No such file or directory' messages
Mads Kiilerich <mads@kiilerich.com>
parents:
12156
diff
changeset
|
5 inexistent1: * (glob) |
117f9190c1ba
tests: hide 'No such file or directory' messages
Mads Kiilerich <mads@kiilerich.com>
parents:
12156
diff
changeset
|
6 inexistent2: * (glob) |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
7 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
8 $ echo bar > foo |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
9 $ hg add foo |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
10 $ hg ci -m 'add foo' |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
11 |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
12 $ echo foobar > foo |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
13 $ hg ci -m 'change foo' |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
14 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
15 $ hg --quiet diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
16 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
17 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
18 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
19 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
20 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
21 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
22 $ hg diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
23 diff -r a99fb63adac3 -r 9b8568d3af2f foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
24 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
25 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
26 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
27 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
28 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
29 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
30 $ hg --verbose diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
31 diff -r a99fb63adac3 -r 9b8568d3af2f foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
32 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
33 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
34 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
35 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
36 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
37 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
38 $ hg --debug diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
39 diff -r a99fb63adac3f31816a22f665bc3b7a7655b30f4 -r 9b8568d3af2f1749445eef03aede868a6f39f210 foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
40 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
41 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
42 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
43 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
44 +foobar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
45 |
16913
f2719b387380
tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents:
15521
diff
changeset
|
46 $ cd .. |