tests/test-check-pylint.t
author Georges Racinet <georges.racinet@octobus.net>
Sun, 29 Oct 2023 10:47:54 +0100
changeset 51241 578c049f0408
parent 49792 4658f5e67e4e
permissions -rw-r--r--
rust-index: using `hg::index::Index` in `hg-cpython::dagops` Hooking `headrevs` to the Rust index is straightforward as long as we go the `PySharedRef` way. Direct attempts of obtaining a reference to the inner `hg::index::Index` fail for lifetime reasons: the reference is bound to the GIL, yet the `as_set` local variable is considered to be static (the borrow checker clearly does not realize or care that this set only stores `Revision` values). In `rank()`, the chosen solution is the simplest as far as `hg-cpython` is concerned, but it has the defect of removing an implementation that would be easily adaptable if the core index did implement `RankedGraph` (returning the same error as long as only `REVLOGV1` is supported), but that would introduce a direct dependency of `hg-core` on the ``vcsgraph` crate.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
49236
e5e3a340b965 tests: remove hg10 requirement from test-check-pylint.t
Anton Shestakov <av6@dwimlabs.net>
parents: 46069
diff changeset
     1
#require test-repo pylint
31413
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     2
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     3
Run pylint for known rules we care about.
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     4
-----------------------------------------
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     5
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     6
There should be no recorded failures; fix the codebase before introducing a
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     7
new check.
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     8
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     9
Current checks:
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    10
- W0102: no mutable default argument
49792
4658f5e67e4e tests: document what the other currently enabled pylint check ensures
Anton Shestakov <av6@dwimlabs.net>
parents: 49236
diff changeset
    11
- C0321: only one statement on a single line
31413
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    12
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    13
  $ touch $TESTTMP/fakerc
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    14
  $ pylint --rcfile=$TESTTMP/fakerc --disable=all \
35630
6061e54ff81d pylint: add a check for multiple statement on a single line
Boris Feld <boris.feld@octobus.net>
parents: 35627
diff changeset
    15
  >   --enable=W0102,C0321 \
35627
882998f08c3c pylint: split command line argument on multiple lines
Boris Feld <boris.feld@octobus.net>
parents: 34395
diff changeset
    16
  >   --reports=no \
34395
41401f502c83 tests: disable lints on mercurial/thirdparty
Siddharth Agarwal <sid0@fb.com>
parents: 32421
diff changeset
    17
  >   --ignore=thirdparty \
38180
6ae62d62c3f6 tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents: 35630
diff changeset
    18
  >   mercurial hgdemandimport hgext hgext3rd | sed 's/\r$//'
6ae62d62c3f6 tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents: 35630
diff changeset
    19
  Using config file *fakerc (glob) (?)
31839
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31413
diff changeset
    20
   (?)
46069
c7899dd29800 tests: update output for test-check-pylint.t
Matt Harbison <matt_harbison@yahoo.com>
parents: 38180
diff changeset
    21
  ------------------------------------* (glob) (?)
c7899dd29800 tests: update output for test-check-pylint.t
Matt Harbison <matt_harbison@yahoo.com>
parents: 38180
diff changeset
    22
  Your code has been rated at 10.00/10* (glob) (?)
31839
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31413
diff changeset
    23
   (?)