Mercurial > hg
annotate tests/test-check-pylint.t @ 39855:62a532045e71
lfs: access revlog directly
LFS is monkeypatching filelog.filelog and is then accessing
various filelog attributes in the monkeypatched function. This is all
fine.
But some of the attributes being accessed by LFS are revlog centric
and shouldn't be exposed on the file storage interface.
This commit changes the monkeypatched functions to access proxied
attributes on self._revlog instead of self.
This should be safe to do because non-revlog repositories should not
be using filelog instances: instead they should have a separate class
to represent file storage. So it is reasonable for LFS to assume the
_revlog attribute exists and points to a revlog.
Differential Revision: https://phab.mercurial-scm.org/D4714
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Thu, 20 Sep 2018 17:47:34 -0700 |
parents | 6ae62d62c3f6 |
children | c7899dd29800 |
rev | line source |
---|---|
31413
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
1 #require test-repo pylint hg10 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
2 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
3 Run pylint for known rules we care about. |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
4 ----------------------------------------- |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
5 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
6 There should be no recorded failures; fix the codebase before introducing a |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
7 new check. |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
8 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
9 Current checks: |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
10 - W0102: no mutable default argument |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
11 |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
12 $ touch $TESTTMP/fakerc |
aa797bd54f44
test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff
changeset
|
13 $ pylint --rcfile=$TESTTMP/fakerc --disable=all \ |
35630
6061e54ff81d
pylint: add a check for multiple statement on a single line
Boris Feld <boris.feld@octobus.net>
parents:
35627
diff
changeset
|
14 > --enable=W0102,C0321 \ |
35627
882998f08c3c
pylint: split command line argument on multiple lines
Boris Feld <boris.feld@octobus.net>
parents:
34395
diff
changeset
|
15 > --reports=no \ |
34395
41401f502c83
tests: disable lints on mercurial/thirdparty
Siddharth Agarwal <sid0@fb.com>
parents:
32421
diff
changeset
|
16 > --ignore=thirdparty \ |
38180
6ae62d62c3f6
tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents:
35630
diff
changeset
|
17 > mercurial hgdemandimport hgext hgext3rd | sed 's/\r$//' |
6ae62d62c3f6
tests: adapt test-check-pylint to run on Windows
Matt Harbison <matt_harbison@yahoo.com>
parents:
35630
diff
changeset
|
18 Using config file *fakerc (glob) (?) |
31839
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
19 (?) |
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
20 ------------------------------------ (?) |
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
21 Your code has been rated at 10.00/10 (?) |
5b048d5f8884
test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents:
31413
diff
changeset
|
22 (?) |