annotate tests/test-issue436 @ 11638:79231258503b stable

transplant: crash if repo.commit() finds nothing to commit (makes issue2135, issue2264 more obvious, but does nothing to fix either one) This seems to happen in two distinct cases: * patch.patch() claims success but changes nothing (e.g. the transplanted changeset adds an empty file that already exists) * patch.patch() makes changes, but repo.status() fails to report them Both of these seem like bugs in other parts of Mercurial, so arguably it's not transplant's job to detect the failure to commit. However: * detecting the problem as soon as possible is desirable * it prevents a more obscure crash later, in transplants.write() * there might be other lurking (or future) bugs that cause repo.commit() to do nothing Also, in the case of issue2264 (source changesets silently dropped by transplant), the only way to spot the problem currently is the crash in transplants.write(). Failure to transplant a patch should abort immediately, whether it's user error (patch does not apply) or a Mercurial bug (e.g. repo.status() failing to report changes).
author Greg Ward <greg-hg@gerg.ca>
date Sun, 18 Jul 2010 21:29:29 -0400
parents f9567a7fa3b3
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
3745
68cddfbbe737 add test for issue436
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
diff changeset
1 #!/bin/sh
68cddfbbe737 add test for issue436
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
diff changeset
2
68cddfbbe737 add test for issue436
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
diff changeset
3 hg init a
68cddfbbe737 add test for issue436
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
diff changeset
4 cd a
3749
f9567a7fa3b3 additional fixes for issue436
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents: 3745
diff changeset
5 hg -v log -v
3745
68cddfbbe737 add test for issue436
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
diff changeset
6 hg -v log -v x
68cddfbbe737 add test for issue436
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
diff changeset
7 true