hgext/remotefilelog/shallowverifier.py

errors: restructure formatparse() to clarify conditions a bit

The `similar` list will be calculated only for
`error.UnknownIdentifier`. It was then printed only if `inst.location
is None`, which is true for that exception type, but it's an indirect
condition to rely on.

Also, it looked from the code like it could both report similarities
and print a hint. That would be a little awkward because the
similarity report looks similar to the hint (both are printed within
parentheses). I also added a `elif` to clarify that. I plan to
refactor this more coming patches so the similarity report actually is
a hint.

Differential Revision: https://phab.mercurial-scm.org/D9343

# shallowverifier.py - shallow repository verifier
#
# Copyright 2015 Facebook, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import

from mercurial.i18n import _
from mercurial import verify


class shallowverifier(verify.verifier):
    def _verifyfiles(self, filenodes, filelinkrevs):
        """Skips files verification since repo's not guaranteed to have them"""
        self.repo.ui.status(
            _(b"skipping filelog check since remotefilelog is used\n")
        )
        return 0, 0