Mercurial > hg
annotate tests/artifacts/PURPOSE @ 39548:7ce9dea3a14a
localrepo: move repo creation logic out of localrepository.__init__ (API)
It has long bothered me that local repository creation is handled as
part of localrepository.__init__. Upcoming changes I want to make
around how repositories are initialized and instantiated will make
the continued existence of repository creation code in
localrepository.__init__ even more awkward.
localrepository instances are almost never constructed directly:
instead, callers are supposed to go through hg.repository() to obtain
a handle on a repository. And hg.repository() calls
localrepo.instance() to return a new repo instance.
This commit teaches localrepo.instance() to handle the create=True
logic. Most of the code for repo construction has been moved to a
standalone function. This allows extensions to monkeypatch the function
to further customize freshly-created repositories.
A few calls to localrepo.localrepository.__init__ that were passing
create=True were converted to call localrepo.instance().
.. api:: local repo creation moved out of constructor
``localrepo.localrepository.__init__`` no longer accepts a
``create`` argument to create a new repository. New repository
creation is now performed as part of ``localrepo.instance()``
and the bulk of the work is performed by
``localrepo.createrepository()``.
Differential Revision: https://phab.mercurial-scm.org/D4534
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 11 Sep 2018 13:46:59 -0700 |
parents | 966950954fda |
children |
rev | line source |
---|---|
39490
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
1 This directory is meant to cache artifacts useful for tests (such as bundle). |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
2 |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
3 Those artifacts need to be cached because they are slow to regenerate on each |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
4 test but too large to be tracked within the repository. They are not expected |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
5 to change between each run and can be cached. |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
6 |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
7 The `./scripts/` contains code to generate the artifact while the `cache` |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
8 directory contains resulting artifact. |
966950954fda
tests: add a `tests/artifacts/` directory
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
9 |