Mercurial > hg
annotate tests/test-check-pyflakes.t @ 39548:7ce9dea3a14a
localrepo: move repo creation logic out of localrepository.__init__ (API)
It has long bothered me that local repository creation is handled as
part of localrepository.__init__. Upcoming changes I want to make
around how repositories are initialized and instantiated will make
the continued existence of repository creation code in
localrepository.__init__ even more awkward.
localrepository instances are almost never constructed directly:
instead, callers are supposed to go through hg.repository() to obtain
a handle on a repository. And hg.repository() calls
localrepo.instance() to return a new repo instance.
This commit teaches localrepo.instance() to handle the create=True
logic. Most of the code for repo construction has been moved to a
standalone function. This allows extensions to monkeypatch the function
to further customize freshly-created repositories.
A few calls to localrepo.localrepository.__init__ that were passing
create=True were converted to call localrepo.instance().
.. api:: local repo creation moved out of constructor
``localrepo.localrepository.__init__`` no longer accepts a
``create`` argument to create a new repository. New repository
creation is now performed as part of ``localrepo.instance()``
and the bulk of the work is performed by
``localrepo.createrepository()``.
Differential Revision: https://phab.mercurial-scm.org/D4534
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 11 Sep 2018 13:46:59 -0700 |
parents | 3ccaf995f549 |
children | 094d0f4a8edd |
rev | line source |
---|---|
29138
a29f071751df
tests: mark test-check-pyflakes.t as requiring hg1.0+
timeless <timeless@mozdev.org>
parents:
27285
diff
changeset
|
1 #require test-repo pyflakes hg10 |
21208
0e1cbd3d52f7
tests: add repository check for pyflakes test
Matt Mackall <mpm@selenic.com>
parents:
20644
diff
changeset
|
2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
29138
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
19377
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
4 |
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
5 run pyflakes on all tracked files ending in .py or without a file ending |
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
6 (skipping binary file random-seed) |
21208
0e1cbd3d52f7
tests: add repository check for pyflakes test
Matt Mackall <mpm@selenic.com>
parents:
20644
diff
changeset
|
7 |
33367
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
8 $ cat > test.py <<EOF |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
9 > print(undefinedname) |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
10 > EOF |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
11 $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
12 test.py:1: undefined name 'undefinedname' |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
13 |
33418
1f3b54f392b0
test-check-pyflakes: do not leave test.py in the repo
Jun Wu <quark@fb.com>
parents:
33367
diff
changeset
|
14 $ cd "`dirname "$TESTDIR"`" |
33367
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
15 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
16 $ testrepohg locate 'set:**.py or grep("^#!.*python")' \ |
33116
6c113a7dec52
tests: use the system hg for examining the local repository
Adam Simpkins <simpkins@fb.com>
parents:
32510
diff
changeset
|
17 > -X hgext/fsmonitor/pywatchman \ |
30894
5b60464efbde
tests: exclude python-zstandard from pyflakes analysis
Augie Fackler <augie@google.com>
parents:
30655
diff
changeset
|
18 > -X mercurial/pycompat.py -X contrib/python-zstandard \ |
37127
0e06d8086295
cbor: fix core test-check*
Pulkit Goyal <7895pulkit@gmail.com>
parents:
33418
diff
changeset
|
19 > -X mercurial/thirdparty/cbor \ |
37625
3ccaf995f549
tests: silence pyflakes for thirdparty/concurrent
Gregory Szorc <gregory.szorc@gmail.com>
parents:
37182
diff
changeset
|
20 > -X mercurial/thirdparty/concurrent \ |
37182
559069689121
tests: ignore zope packages when running pyflakes
Gregory Szorc <gregory.szorc@gmail.com>
parents:
37127
diff
changeset
|
21 > -X mercurial/thirdparty/zope \ |
29584
06587edd1233
pycompat: make pycompat demandimport friendly
Pulkit Goyal <7895pulkit@gmail.com>
parents:
29232
diff
changeset
|
22 > 2>/dev/null \ |
19377
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
23 > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" |
22053
4354b1e35f53
tests: fix pyflakes test whitespace breakage
Matt Mackall <mpm@selenic.com>
parents:
22047
diff
changeset
|
24 |