hgext/closehead.py

exchange: improve computation of relevant markers for large repos

Compute the candidate nodes with relevant markers directly
from keys of the predecessors/successors/children dictionaries of
obsstore. This is faster than iterating over all nodes directly.
This test could be further improved for repositories with relative
few markers compared to the repository size, but this is no longer
hot already. With the current loop structure, the obshashrange use
works as well as before as it passes lists with a single node.

Adjust the interface by allowing revision lists as well as node lists.
This helps cases that computes ancestors as it reduces the
materialisation cost. Use this in _pushdiscoveryobsmarker and
_getbundleobsmarkerpart. Improve the latter further by directly using
ancestors().


Performance benchmarks show notable and welcome improvement to no-op push and
pull (that would also apply to other push/pull). This apply to push and pull
done without evolve.

### push/pull Benchmark parameter
  # bin-env-vars.hg.flavor          = default
  # benchmark.variants.explicit-rev = none
  # benchmark.variants.protocol     = ssh
  # benchmark.variants.revs         = none

 ## benchmark.name                  = hg.command.pull
  # data-env-vars.name              = mercurial-devel-2024-03-22-zstd-sparse-revlog
before: 5.968537 seconds
after:  5.668507 seconds (-5.03%, -0.30)
  # data-env-vars.name              = tryton-devel-2024-03-22-zstd-sparse-revlog
before: 1.446232 seconds
after:  0.835553 seconds (-42.23%, -0.61)
  # data-env-vars.name              = netbsd-src-draft-2024-09-19-zstd-sparse-revlog
before: 5.777412 seconds
after:  2.523454 seconds (-56.32%, -3.25)

 ## benchmark.name                  = hg.command.push
  # data-env-vars.name              = mercurial-devel-2024-03-22-zstd-sparse-revlog
before: 6.155501 seconds
after:  5.885072 seconds (-4.39%, -0.27)

  # data-env-vars.name              = tryton-devel-2024-03-22-zstd-sparse-revlog
before: 1.491054 seconds
after:  0.934882 seconds (-37.30%, -0.56)

  # data-env-vars.name              = netbsd-src-draft-2024-09-19-zstd-sparse-revlog
before: 5.902494 seconds
after:  2.957644 seconds (-49.89%, -2.94)

There is not notable different in these result using the "rust" flavor instead
of the "default".  The performance impact on the same operation when using
evolve were also tested and no impact was noted.

# closehead.py - Close arbitrary heads without checking them out first
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.

'''close arbitrary heads without checking them out first'''

from __future__ import annotations

from mercurial.i18n import _
from mercurial import (
    bookmarks,
    cmdutil,
    context,
    error,
    logcmdutil,
    pycompat,
    registrar,
)

cmdtable = {}
command = registrar.command(cmdtable)
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified.
testedwith = b'ships-with-hg-core'

commitopts = cmdutil.commitopts
commitopts2 = cmdutil.commitopts2
commitopts3 = [(b'r', b'rev', [], _(b'revision to check'), _(b'REV'))]


@command(
    b'close-head|close-heads',
    commitopts + commitopts2 + commitopts3,
    _(b'[OPTION]... [REV]...'),
    helpcategory=command.CATEGORY_CHANGE_MANAGEMENT,
    inferrepo=True,
)
def close_branch(ui, repo, *revs, **opts):
    """close the given head revisions

    This is equivalent to checking out each revision in a clean tree and running
    ``hg commit --close-branch``, except that it doesn't change the working
    directory.

    The commit message must be specified with -l or -m.
    """

    def docommit(rev):
        cctx = context.memctx(
            repo,
            parents=[rev, None],
            text=message,
            files=[],
            filectxfn=None,
            user=opts.get('user'),
            date=opts.get('date'),
            extra=extra,
        )
        with repo.transaction(b'commit'):
            ret = repo.commitctx(cctx, True)
            bookmarks.update(repo, [rev, None], ret)
            cctx.markcommitted(ret)

    revs += tuple(opts.get('rev', []))
    revs = logcmdutil.revrange(repo, revs)

    if not revs:
        raise error.Abort(_(b'no revisions specified'))

    heads = []
    for branch in repo.branchmap():
        heads.extend(repo.branchheads(branch))
    heads = {repo[h].rev() for h in heads}
    for rev in revs:
        if rev not in heads:
            raise error.Abort(_(b'revision is not an open head: %d') % rev)

    message = cmdutil.logmessage(ui, pycompat.byteskwargs(opts))
    if not message:
        raise error.Abort(_(b"no commit message specified with -l or -m"))
    extra = {b'close': b'1'}

    with repo.wlock(), repo.lock():
        for rev in revs:
            r = repo[rev]
            branch = r.branch()
            extra[b'branch'] = branch
            docommit(r)
    return 0