annotate tests/test-audit-path.t @ 52060:8b7123c8947b

update: add a Rust fast-path when updating from null (and clean)

This case is easy to detect and we have all we need to generate a valid
working copy and dirstate entirely in Rust, which speeds things up
considerably:

On my machine updating a repo of ~300k files goes from 10.00s down to 4.2s,
all while consuming 50% less system time, with all caches hot.
Something to note is that further improvements will probably happen
with the upcoming `InnerRevlog` series that does smarter
mmap hanlding, especially for filelogs.

Here are benchmark numbers on a machine with only 4 cores (and no SMT enabled)

```
### data-env-vars.name               = heptapod-public-2024-03-25-ds2-pnm
  # benchmark.name                   = hg.command.update
  # bin-env-vars.hg.py-re2-module    = default
  # bin-env-vars.hg.changeset.node   = <this change>
  # benchmark.variants.atomic-update = no
  # benchmark.variants.scenario      = null-to-tip
  # benchmark.variants.worker        = default
default: 5.328762  ~~~~~
rust: 1.308654  (-75.44%, -4.02)
### data-env-vars.name               = mercurial-devel-2024-03-22-ds2-pnm
  # benchmark.name                   = hg.command.update
  # bin-env-vars.hg.py-re2-module    = default
  # bin-env-vars.hg.changeset.node   = <this change>
  # benchmark.variants.atomic-update = no
  # benchmark.variants.scenario      = null-to-tip
  # benchmark.variants.worker        = default
default: 1.693271  ~~~~~
rust: 1.151053  (-32.02%, -0.54)
### data-env-vars.name               = mozilla-unified-2024-03-22-ds2-pnm
  # benchmark.name                   = hg.command.update
  # bin-env-vars.hg.py-re2-module    = default
  # bin-env-vars.hg.changeset.node   = <this change>
  # benchmark.variants.atomic-update = no
  # benchmark.variants.scenario      = null-to-tip
  # benchmark.variants.worker        = default
default: 38.901613  ~~~~~
rust: 11.637880 (-70.08%, -27.26)
### data-env-vars.name               = netbsd-xsrc-public-2024-09-19-ds2-pnm
  # benchmark.name                   = hg.command.update
  # bin-env-vars.hg.py-re2-module    = default
  # bin-env-vars.hg.changeset.node   = <this change>
  # benchmark.variants.atomic-update = no
  # benchmark.variants.scenario      = null-to-tip
  # benchmark.variants.worker        = default
default: 4.793727  ~~~~~
rust: 1.505905  (-68.59%, -3.29)
```

The simple store doesn't escape paths robustly and can't store paths
with periods, etc. So much of this test fails with it.
#require no-reposimplestore

  $ hg init repo
  $ cd repo

audit of .hg

  $ hg add .hg/00changelog.i
  abort: path contains illegal component: .hg/00changelog.i
  [10]

#if symlink

Symlinks

  $ mkdir a
  $ echo a > a/a
  $ hg ci -Ama
  adding a/a
  $ ln -s a b
  $ echo b > a/b
  $ hg add b/b
  abort: path 'b/b' traverses symbolic link 'b'
  [255]
  $ hg add b

should still fail - maybe

  $ hg add b/b
  abort: path 'b/b' traverses symbolic link 'b'
  [255]

  $ hg commit -m 'add symlink b'


Test symlink traversing when accessing history:
-----------------------------------------------

(build a changeset where the path exists as a directory)

  $ hg up 0
  0 files updated, 0 files merged, 1 files removed, 0 files unresolved
  $ mkdir b
  $ echo c > b/a
  $ hg add b/a
  $ hg ci -m 'add directory b'
  created new head

Test that hg cat does not do anything wrong the working copy has 'b' as directory

  $ hg cat b/a
  c
  $ hg cat -r "desc(directory)" b/a
  c
  $ hg cat -r "desc(symlink)" b/a
  b/a: no such file in rev bc151a1f53bd
  [1]

Test that hg cat does not do anything wrong the working copy has 'b' as a symlink (issue4749)

  $ hg up 'desc(symlink)'
  1 files updated, 0 files merged, 1 files removed, 0 files unresolved
  $ hg cat b/a
  b/a: no such file in rev bc151a1f53bd
  [1]
  $ hg cat -r "desc(directory)" b/a
  c
  $ hg cat -r "desc(symlink)" b/a
  b/a: no such file in rev bc151a1f53bd
  [1]

#endif


unbundle tampered bundle

  $ hg init target
  $ cd target
  $ hg unbundle "$TESTDIR/bundles/tampered.hg"
  adding changesets
  adding manifests
  adding file changes
  added 5 changesets with 6 changes to 6 files (+4 heads)
  new changesets b7da9bf6b037:fc1393d727bc (5 drafts)
  (run 'hg heads' to see heads, 'hg merge' to merge)

attack .hg/test

  $ hg manifest -r0
  .hg/test
  $ hg update -Cr0
  abort: path contains illegal component: .hg/test (no-rust !)
  abort: path '.hg/test' is inside the '.hg' folder (rust !)
  [10]

attack foo/.hg/test

  $ hg manifest -r1
  foo/.hg/test
  $ hg update -Cr1
  abort: path 'foo/.hg/test' is inside nested repo 'foo'
  [10]

attack back/test where back symlinks to ..

  $ hg manifest -r2
  back
  back/test

#if symlink
  $ hg update -Cr2
  abort: path 'back/test' traverses symbolic link 'back'
  [255]
#else
('back' will be a file and cause some other system specific error)
  $ hg update -Cr2
  abort: $TESTTMP/repo/target/back/test: $ENOTDIR$
  [255]
#endif

attack ../test

  $ hg manifest -r3
  ../test
  $ mkdir ../test
  $ echo data > ../test/file
  $ hg update -Cr3
  abort: path contains illegal component: ../test
  [10]
  $ cat ../test/file
  data

attack /tmp/test

  $ hg manifest -r4
  /tmp/test
  $ hg update -Cr4
  abort: path contains illegal component: /tmp/test
  [10]

  $ cd ..

Test symlink traversal on merge:
--------------------------------

#if symlink

set up symlink hell

  $ mkdir merge-symlink-out
  $ hg init merge-symlink
  $ cd merge-symlink
  $ touch base
  $ hg commit -qAm base
  $ ln -s ../merge-symlink-out a
  $ hg commit -qAm 'symlink a -> ../merge-symlink-out'
  $ hg up -q 0
  $ mkdir a
  $ touch a/poisoned
  $ hg commit -qAm 'file a/poisoned'
  $ hg log -G -T '{rev}: {desc}\n'
  @  2: file a/poisoned
  |
  | o  1: symlink a -> ../merge-symlink-out
  |/
  o  0: base
  

try trivial merge

  $ hg up -qC 1
  $ hg merge 2
  abort: path 'a/poisoned' traverses symbolic link 'a'
  [255]

try rebase onto other revision: cache of audited paths should be discarded,
and the rebase should fail (issue5628)

  $ hg up -qC 2
  $ hg rebase -s 2 -d 1 --config extensions.rebase=
  rebasing 2:e73c21d6b244 tip "file a/poisoned"
  abort: path 'a/poisoned' traverses symbolic link 'a'
  [255]
  $ ls ../merge-symlink-out

  $ cd ..

Test symlink traversal on update:
---------------------------------

  $ mkdir update-symlink-out
  $ hg init update-symlink
  $ cd update-symlink
  $ ln -s ../update-symlink-out a
  $ hg commit -qAm 'symlink a -> ../update-symlink-out'
  $ hg rm a
  $ mkdir a && touch a/b
  $ hg ci -qAm 'file a/b' a/b
  $ hg up -qC 0
  $ hg rm a
  $ mkdir a && touch a/c
  $ hg ci -qAm 'rm a, file a/c'
  $ hg log -G -T '{rev}: {desc}\n'
  @  2: rm a, file a/c
  |
  | o  1: file a/b
  |/
  o  0: symlink a -> ../update-symlink-out
  

try linear update where symlink already exists:

  $ hg up -qC 0
  $ hg up 1
  abort: path 'a/b' traverses symbolic link 'a'
  [255]

try linear update including symlinked directory and its content: paths are
audited first by calculateupdates(), where no symlink is created so both
'a' and 'a/b' are taken as good paths. still applyupdates() should fail.

  $ hg up -qC null
#if rust
  $ hg up 1
  abort: path 'a/*' traverses symbolic link 'a'
  [10]
#endif

#if no-rust
  $ hg up 1
  abort: path 'a/b' traverses symbolic link 'a'
  [255]
#endif
  $ ls ../update-symlink-out

try branch update replacing directory with symlink, and its content: the
path 'a' is audited as a directory first, which should be audited again as
a symlink.

#if rust
  $ rm -rf a
#else
  $ rm -f a
#endif
  $ hg up -qC 2

  $ hg up 1
  abort: path 'a/b' traverses symbolic link 'a'
  [255]
  $ ls ../update-symlink-out

  $ cd ..

#endif