tests/cgienv
author Kyle Lippincott <spectral@google.com>
Wed, 27 Jan 2021 10:29:21 -0800
branchstable
changeset 46415 8deab876fb59
parent 13269 aa3f726a2bdb
permissions -rw-r--r--
wix: tell ComponentSearch that it is finding a directory (not a file) This is to fix an issue we've noticed where fresh installations start at `C:\Program Files\Mercurial`, and then upgrades "walk up" the tree and end up in `C:\Program Files` and finally `C:\` (where they stay). ComponentSearch defaults to finding files, which I think means "it produces a string like `C:\Program Files\Mercurial`", whereas with the type being explicitly a directory, it would return `C:\Program Files\Mercurial\` (note the final trailing backslash). Presumably, a latter step then tries to turn that file name into a proper directory, by removing everything after the last `\`. This could likely also be fixed by actually searching for the component for hg.exe itself. That seemed a lot more complicated, as the GUID for hg.exe isn't known in this file (it's one of the "auto-derived" ones). We could also consider adding a Condition that I think could check the Property and ensure it's either empty or ends in a trailing slash, but that would be an installer runtime check and I'm not convinced it'd actually be useful. This will *not* cause existing installations that are in one of the bad directories to fix themselves. Doing that would require a fair amount more understanding of wix and windows installer than I have, and it *probably* wouldn't be possible to be 100% correct about it either (there's nothing preventing a user from intentionally installing it in C:\, though I don't know why they would do so). If someone wants to tackle fixing existing installations, I think that the first installation is actually the only one that shows up in "Add or Remove Programs", and that its registry keys still exist. You might be able to find something under HKEY_USERS that lists both the "good" and the "bad" InstallDirs. Mine was under `HKEY_USERS\S-1-5-18\Software\Mercurial\InstallDir` (C:\), and `HKEY_USERS\S-1-5-21-..numbers..\Software\Mercurial\InstallDir` (C:\Program Files\Mercurial). If you find exactly two, with one being the default path, and the other being a prefix of it, the user almost certainly hit this bug :D We had originally thought that this bug might be due to unattended installations/upgrades, but I no longer think that's the case. We were able to reproduce the issue by uninstalling all copies of Mercurial I could find, installing one version (it chose the correct location), and then starting the installer for a different version (higher or lower didn't matter). I did not need to deal with an unattended or headless installation/upgrade to trigger the issue, but it's possible that my system was "primed" for this bug to happen because of a previous unattended installation/upgrade. Differential Revision: https://phab.mercurial-scm.org/D9891
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
13269
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     1
DOCUMENT_ROOT="/var/www/hg"; export DOCUMENT_ROOT
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     2
GATEWAY_INTERFACE="CGI/1.1"; export GATEWAY_INTERFACE
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     3
HTTP_ACCEPT="text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"; export HTTP_ACCEPT
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     4
HTTP_ACCEPT_CHARSET="ISO-8859-1,utf-8;q=0.7,*;q=0.7"; export HTTP_ACCEPT_CHARSET
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     5
HTTP_ACCEPT_ENCODING="gzip,deflate"; export HTTP_ACCEPT_ENCODING
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     6
HTTP_ACCEPT_LANGUAGE="en-us,en;q=0.5"; export HTTP_ACCEPT_LANGUAGE
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     7
HTTP_CACHE_CONTROL="max-age=0"; export HTTP_CACHE_CONTROL
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     8
HTTP_CONNECTION="keep-alive"; export HTTP_CONNECTION
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
     9
HTTP_HOST="hg.omnifarious.org"; export HTTP_HOST
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    10
HTTP_KEEP_ALIVE="300"; export HTTP_KEEP_ALIVE
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    11
HTTP_USER_AGENT="Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.4) Gecko/20060608 Ubuntu/dapper-security Firefox/1.5.0.4"; export HTTP_USER_AGENT
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    12
PATH_INFO="/"; export PATH_INFO
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    13
PATH_TRANSLATED="/var/www/hg/index.html"; export PATH_TRANSLATED
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    14
QUERY_STRING=""; export QUERY_STRING
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    15
REMOTE_ADDR="127.0.0.2"; export REMOTE_ADDR
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    16
REMOTE_PORT="44703"; export REMOTE_PORT
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    17
REQUEST_METHOD="GET"; export REQUEST_METHOD
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    18
REQUEST_URI="/test/"; export REQUEST_URI
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    19
SCRIPT_FILENAME="/home/hopper/hg_public/test.cgi"; export SCRIPT_FILENAME
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    20
SCRIPT_NAME="/test"; export SCRIPT_NAME
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    21
SCRIPT_URI="http://hg.omnifarious.org/test/"; export SCRIPT_URI
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    22
SCRIPT_URL="/test/"; export SCRIPT_URL
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    23
SERVER_ADDR="127.0.0.1"; export SERVER_ADDR
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    24
SERVER_ADMIN="eric@localhost"; export SERVER_ADMIN
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    25
SERVER_NAME="hg.omnifarious.org"; export SERVER_NAME
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    26
SERVER_PORT="80"; export SERVER_PORT
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    27
SERVER_PROTOCOL="HTTP/1.1"; export SERVER_PROTOCOL
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    28
SERVER_SIGNATURE="<address>Apache/2.0.53 (Fedora) Server at hg.omnifarious.org Port 80</address>"; export SERVER_SIGNATURE
aa3f726a2bdb tests: remove duplication of the CGI environment variables
StevenGBrown
parents:
diff changeset
    29
SERVER_SOFTWARE="Apache/2.0.53 (Fedora)"; export SERVER_SOFTWARE