Mercurial > hg
annotate contrib/chg/util.h @ 45095:8e04607023e5
procutil: ensure that procutil.std{out,err}.write() writes all bytes
Python 3 offers different kind of streams and it’s not guaranteed for all of
them that calling write() writes all bytes.
When Python is started in unbuffered mode, sys.std{out,err}.buffer are
instances of io.FileIO, whose write() can write less bytes for
platform-specific reasons (e.g. Linux has a 0x7ffff000 bytes maximum and could
write less if interrupted by a signal; when writing to Windows consoles, it’s
limited to 32767 bytes to avoid the "not enough space" error). This can lead to
silent loss of data, both when using sys.std{out,err}.buffer (which may in fact
not be a buffered stream) and when using the text streams sys.std{out,err}
(I’ve created a CPython bug report for that:
https://bugs.python.org/issue41221).
Python may fix the problem at some point. For now, we implement our own wrapper
for procutil.std{out,err} that calls the raw stream’s write() method until all
bytes have been written. We don’t use sys.std{out,err} for larger writes, so I
think it’s not worth the effort to patch them.
author | Manuel Jacob <me@manueljacob.de> |
---|---|
date | Fri, 10 Jul 2020 12:27:58 +0200 |
parents | 9724f54923ec |
children |
rev | line source |
---|---|
28060 | 1 /* |
2 * Utility functions | |
3 * | |
4 * Copyright (c) 2011 Yuya Nishihara <yuya@tcha.org> | |
5 * | |
6 * This software may be used and distributed according to the terms of the | |
7 * GNU General Public License version 2 or any later version. | |
8 */ | |
9 | |
10 #ifndef UTIL_H_ | |
11 #define UTIL_H_ | |
12 | |
13 #ifdef __GNUC__ | |
14 #define PRINTF_FORMAT_ __attribute__((format(printf, 1, 2))) | |
29440
009cc6c89d0f
chg: silence warning of unused parameter 'sig'
Yuya Nishihara <yuya@tcha.org>
parents:
28855
diff
changeset
|
15 #define UNUSED_ __attribute__((unused)) |
28604
d4d8a3c89e6d
chg: define PRINTF_FORMAT_ for non gnu C compiler
Jun Wu <quark@fb.com>
parents:
28165
diff
changeset
|
16 #else |
d4d8a3c89e6d
chg: define PRINTF_FORMAT_ for non gnu C compiler
Jun Wu <quark@fb.com>
parents:
28165
diff
changeset
|
17 #define PRINTF_FORMAT_ |
29440
009cc6c89d0f
chg: silence warning of unused parameter 'sig'
Yuya Nishihara <yuya@tcha.org>
parents:
28855
diff
changeset
|
18 #define UNUSED_ |
28060 | 19 #endif |
20 | |
21 void abortmsg(const char *fmt, ...) PRINTF_FORMAT_; | |
28788
57a78a64de44
chg: add util function abortmsgerrno to print error with errno
Jun Wu <quark@fb.com>
parents:
28787
diff
changeset
|
22 void abortmsgerrno(const char *fmt, ...) PRINTF_FORMAT_; |
28060 | 23 |
28787
ea86cdcd9b50
chg: use color in debug/error messages conditionally
Jun Wu <quark@fb.com>
parents:
28604
diff
changeset
|
24 void enablecolor(void); |
28060 | 25 void enabledebugmsg(void); |
26 void debugmsg(const char *fmt, ...) PRINTF_FORMAT_; | |
27 | |
28854
ddef14468952
chg: add fchdirx as a utility function
Jun Wu <quark@fb.com>
parents:
28788
diff
changeset
|
28 void fchdirx(int dirfd); |
28855
f5764e177bbe
chg: extract the logic of setting FD_CLOEXEC to a utility function
Jun Wu <quark@fb.com>
parents:
28854
diff
changeset
|
29 void fsetcloexec(int fd); |
28165
c6705c6303dd
chg: add utility functions mallocx, reallocx
Jun Wu <quark@fb.com>
parents:
28060
diff
changeset
|
30 void *mallocx(size_t size); |
c6705c6303dd
chg: add utility functions mallocx, reallocx
Jun Wu <quark@fb.com>
parents:
28060
diff
changeset
|
31 void *reallocx(void *ptr, size_t size); |
c6705c6303dd
chg: add utility functions mallocx, reallocx
Jun Wu <quark@fb.com>
parents:
28060
diff
changeset
|
32 |
28060 | 33 int runshellcmd(const char *cmd, const char *envp[], const char *cwd); |
34 | |
35959
9724f54923ec
chg: enable clang-format on all .c and .h files
Augie Fackler <augie@google.com>
parents:
29440
diff
changeset
|
35 #endif /* UTIL_H_ */ |