tests/test-check-code
author Martin Geisler <mg@aragost.com>
Tue, 15 Jun 2010 09:51:52 +0200
changeset 11341 920a783e5f91
parent 10727 62b8f15683f2
child 11343 f325db39c8b9
permissions -rwxr-xr-x
check-code: fix check for any/all function The old check would only detect any/all at the beginning of a line. The regexp was probably just modeled after the preceding regexp which (correctly) finds the 'with' keyword at the beginning of a line. We now complain about 'any(' and 'all(' anywhere in a line, unless it is preceded by 'def'. This allows us to define our own compatibility wrapper in util and use 'util.any(' in the code.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10715
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     1
#!/bin/sh
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     2
#cd `dirname $0`
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     3
cat > correct.py <<EOF
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     4
def toto(arg1, arg2):
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     5
    del arg2
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     6
    return (5 + 6, 9)
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     7
EOF
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     8
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
     9
cat > wrong.py <<EOF
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
    10
def toto( arg1, arg2):
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
    11
    del(arg2)
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
    12
    return ( 5+6, 9)
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
    13
EOF
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
    14
10722
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    15
cat > quote.py <<EOF
10727
62b8f15683f2 check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10722
diff changeset
    16
# let's use quote in comments
10722
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    17
(''' ( 4x5 )
10727
62b8f15683f2 check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10722
diff changeset
    18
but """\\''' and finally''',
10722
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    19
"""let's fool checkpatch""", '1+2',
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    20
'"""', 42+1, """and
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    21
( 4-1 ) """, "( 1+1 )\" and ")
10727
62b8f15683f2 check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10722
diff changeset
    22
a, '\\\\\\\\', "\\\\\\" x-2", "c-1"
10722
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    23
EOF
c4fb2103e734 check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents: 10715
diff changeset
    24
11341
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    25
cat > non-py24.py <<EOF
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    26
# Using builtins that does not exist in Python 2.4
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    27
if any():
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    28
    x = all()
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    29
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    30
# Do not complain about our own definition
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    31
def any(x):
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    32
    pass
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    33
EOF
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    34
10715
83dce0f817f4 add a small test for contrib/check-code.py
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
diff changeset
    35
check_code=`dirname $0`/../contrib/check-code.py
11341
920a783e5f91 check-code: fix check for any/all function
Martin Geisler <mg@aragost.com>
parents: 10727
diff changeset
    36
${check_code} ./wrong.py ./correct.py ./quote.py ./non-py24.py