Mercurial > hg
annotate contrib/clang-format-ignorelist @ 51723:9367571fea21
cext: correct the argument handling of `b85encode()`
The type stub indicated that this argument is `Optional`, which implies None is
allowed. I don't see in the documentation where that's the case for `i`[1], and
trying it in `hg debugshell` resulted in the method failing with a TypeError. I
guess it was typed as an `int` argument because the `p` format unit wasn't added
until Python 3.3[2].
In any event, 2 clients in core (`pvec` and `obsolete`) call this with no
argument supplied, and `mdiff` calls it with True. So I guess we've avoided the
None arg case, and when no arg is supplied, it defaults to the 0 initialization
of the `pad` variable in C. Since the `p` format unit accepts both `int` and
None, as well as `bool`, I'm not bothering to bump the module version- this code
is more permissive than it was, in addition to being more correct.
Interestingly, when I first imported the `cext` and `pure` methods in the same
manner as the previous commit, it dropped the `Optional` part of the argument
type when generating `util.pyi`. No idea why.
[1] https://docs.python.org/3/c-api/arg.html#numbers
[2] https://docs.python.org/3/c-api/arg.html#other-objects
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 20 Jul 2024 01:55:09 -0400 |
parents | e92ca942ddca |
children |
rev | line source |
---|---|
34834
2e8477059d4f
test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
1 # Files that just need to be migrated to the formatter. |
2e8477059d4f
test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
2 # Do not add new files here! |
2e8477059d4f
test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
3 mercurial/cext/manifest.c |
2e8477059d4f
test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
4 mercurial/cext/osutil.c |
2e8477059d4f
test-clang-format: new test to verify that files stay clang-formatted
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
5 # Vendored code that we should never format: |
44037
98944715a02c
fix: convert clang-format-ignorelist to use wildcards
Kyle Lippincott <spectral@google.com>
parents:
43994
diff
changeset
|
6 syntax: glob |
98944715a02c
fix: convert clang-format-ignorelist to use wildcards
Kyle Lippincott <spectral@google.com>
parents:
43994
diff
changeset
|
7 contrib/python-zstandard/**.c |
98944715a02c
fix: convert clang-format-ignorelist to use wildcards
Kyle Lippincott <spectral@google.com>
parents:
43994
diff
changeset
|
8 contrib/python-zstandard/**.h |
98944715a02c
fix: convert clang-format-ignorelist to use wildcards
Kyle Lippincott <spectral@google.com>
parents:
43994
diff
changeset
|
9 hgext/fsmonitor/pywatchman/**.c |
98944715a02c
fix: convert clang-format-ignorelist to use wildcards
Kyle Lippincott <spectral@google.com>
parents:
43994
diff
changeset
|
10 mercurial/thirdparty/**.c |
98944715a02c
fix: convert clang-format-ignorelist to use wildcards
Kyle Lippincott <spectral@google.com>
parents:
43994
diff
changeset
|
11 mercurial/thirdparty/**.h |
46374
e92ca942ddca
cext: add Python 3.10 support
Victor Stinner <vstinner@python.org>
parents:
44037
diff
changeset
|
12 mercurial/pythoncapi_compat.h |