Mercurial > hg
annotate mercurial/__main__.py @ 51723:9367571fea21
cext: correct the argument handling of `b85encode()`
The type stub indicated that this argument is `Optional`, which implies None is
allowed. I don't see in the documentation where that's the case for `i`[1], and
trying it in `hg debugshell` resulted in the method failing with a TypeError. I
guess it was typed as an `int` argument because the `p` format unit wasn't added
until Python 3.3[2].
In any event, 2 clients in core (`pvec` and `obsolete`) call this with no
argument supplied, and `mdiff` calls it with True. So I guess we've avoided the
None arg case, and when no arg is supplied, it defaults to the 0 initialization
of the `pad` variable in C. Since the `p` format unit accepts both `int` and
None, as well as `bool`, I'm not bothering to bump the module version- this code
is more permissive than it was, in addition to being more correct.
Interestingly, when I first imported the `cext` and `pure` methods in the same
manner as the previous commit, it dropped the `Optional` part of the argument
type when generating `util.pyi`. No idea why.
[1] https://docs.python.org/3/c-api/arg.html#numbers
[2] https://docs.python.org/3/c-api/arg.html#other-objects
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 20 Jul 2024 01:55:09 -0400 |
parents | e7ef11b75fdc |
children | 1c5810ce737e |
rev | line source |
---|---|
50697
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
1 def run(): |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
2 from . import demandimport |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
3 |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
4 with demandimport.tracing.log('hg script'): |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
5 demandimport.enable() |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
6 from . import dispatch |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
7 |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
8 dispatch.run() |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
9 |
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
10 |
50696
eb01d3a65ad8
library: enable runpy invocation on mercurial package
Jason R. Coombs <jaraco@jaraco.com>
parents:
diff
changeset
|
11 if __name__ == '__main__': |
50697
e7ef11b75fdc
library: incorporate demandimport into runpy invocation
Jason R. Coombs <jaraco@jaraco.com>
parents:
50696
diff
changeset
|
12 run() |