tests/phabricator/phabsend-create-alpha.json

commit: improve the files field of changelog for merges

Currently, the files list of merge commits repeats all the deletions
(either actual deletions, or files that got renamed) that happened
between base and p2 of the merge. If p2 is the main branch, the list
can easily be much bigger than the change being merged.

This results in various problems worth improving:
- changelog is bigger than necessary
- `hg log directory` lists many unrelated merge commits, and `hg log
  -v -r commit` frequently fills multiple screens worth of files
- it possibly slows down adjustlinkrev, by forcing it to read more
  manifests, and that function can certainly be a bottleneck
- the server side of pulls can waste a lot of time simply opening the
  filelogs for pointless files (the constant factors for opening even
  a tiny filelog is apparently pretty bad)

So stop listing such files as described in the code.  Impacted merge
commits and their descendants get a different hash than they would
have without this. This doesn't seem problematic, except for
convert. The previous commit helped with that in the hg->hg case (but
if you do svn->hg twice from scratch, hashes can still change).

The rest of the description is numbers. I don't have much to report,
because recreating the files list of existing repositories is not
easy:
- debugupgradeformat and bundle/unbundle don't recreate the list
- export/import tends to choke quickly applying patches or on
  description that contain diffs,
- merge commits from the convert extension don't have the right files
  list for reasons orthogonal to the current commit
- replaying the merge with hg update/hg merge/hg revert --all/hg
  commit can end up failing in hg revert
- I wasn't sure that using debugsetparents + debugrebuilddirstate
  would really build the right thing

I measured commit time before and after this change, in a case with no
files filtered out, several files filtered out (no difference) and 5k
files filtered out (+1% time).

Recreating the 100 more recent merges in a private repo, the
concatenated uncompressed files lists goes from 1.12MB to
0.52MB. Excluding 3 merges that are not representative, then the size
goes from 570k to 15k.
I converted part of mozilla-central, and observed file list shrinking
quite a bit too, starting at the very first merge, 733641d9feaf, going
from 550 files to 10 files (although they have relatively few merges,
so they probably wouldn't care).

Differential Revision: https://phab.mercurial-scm.org/D6613

{
    "version": 1,
    "interactions": [
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "93"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "api.token=cli-hahayouwish&constraints%5Bcallsigns%5D%5B0%5D=HG",
                "uri": "https://phab.mercurial-scm.org//api/diffusion.repository.search",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:00 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "549"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":{\"data\":[{\"id\":10,\"type\":\"REPO\",\"phid\":\"PHID-REPO-bvunnehri4u2isyr7bc3\",\"fields\":{\"name\":\"Mercurial\",\"vcs\":\"hg\",\"callsign\":\"HG\",\"shortName\":\"Mercurial\",\"status\":\"active\",\"isImporting\":false,\"almanacServicePHID\":null,\"spacePHID\":null,\"dateCreated\":1507817156,\"dateModified\":1529613276,\"policy\":{\"view\":\"public\",\"edit\":\"admin\",\"diffusion.push\":\"users\"}},\"attachments\":{}}],\"maps\":{},\"query\":{\"queryKey\":null},\"cursor\":{\"limit\":100,\"after\":null,\"before\":null,\"order\":null}},\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "235"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "api.token=cli-hahayouwish&diff=diff+--git+a%2Falpha+b%2Falpha%0Anew+file+mode+100644%0A---+%2Fdev%2Fnull%0A%2B%2B%2B+b%2Falpha%0A%40%40+-0%2C0+%2B1%2C1+%40%40%0A%2Balpha%0A&repositoryPHID=PHID-REPO-bvunnehri4u2isyr7bc3",
                "uri": "https://phab.mercurial-scm.org//api/differential.createrawdiff",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:01 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "172"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":{\"id\":1899,\"phid\":\"PHID-DIFF-gpg57jico75ouhl2bux2\",\"uri\":\"https:\\/\\/phab.mercurial-scm.org\\/differential\\/diff\\/1899\\/\"},\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "296"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "diff_id=1899&data=%7B%22branch%22%3A+%22default%22%2C+%22date%22%3A+%220+0%22%2C+%22node%22%3A+%22d386117f30e6b1282897bdbde75ac21e095163d4%22%2C+%22parent%22%3A+%220000000000000000000000000000000000000000%22%2C+%22user%22%3A+%22test%22%7D&name=hg%3Ameta&api.token=cli-hahayouwish",
                "uri": "https://phab.mercurial-scm.org//api/differential.setdiffproperty",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:02 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "51"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":null,\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "257"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "diff_id=1899&data=%7B%22d386117f30e6b1282897bdbde75ac21e095163d4%22%3A+%7B%22author%22%3A+%22test%22%2C+%22authorEmail%22%3A+%22test%22%2C+%22branch%22%3A+%22default%22%2C+%22commit%22%3A+%22d386117f30e6b1282897bdbde75ac21e095163d4%22%2C+%22parents%22%3A+%5B%220000000000000000000000000000000000000000%22%5D%2C+%22time%22%3A+0%7D%7D&name=local%3Acommits&api.token=cli-hahayouwish",
                "uri": "https://phab.mercurial-scm.org//api/differential.setdiffproperty",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:02 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "51"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":null,\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "93"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "api.token=cli-hahayouwish&corpus=create+alpha+for+phabricator+test+%E2%82%AC",
                "uri": "https://phab.mercurial-scm.org//api/differential.parsecommitmessage",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:03 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "298"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":{\"errors\":[],\"fields\":{\"title\":\"create alpha for phabricator test \\u20ac\"},\"revisionIDFieldInfo\":{\"value\":null,\"validDomain\":\"https:\\/\\/phab.mercurial-scm.org\"},\"transactions\":[{\"type\":\"title\",\"value\":\"create alpha for phabricator test \\u20ac\"}]},\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "252"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "api.token=cli-hahayouwish&transactions%5B0%5D%5Btype%5D=update&transactions%5B0%5D%5Bvalue%5D=PHID-DIFF-gpg57jico75ouhl2bux2&transactions%5B1%5D%5Btype%5D=title&transactions%5B1%5D%5Bvalue%5D=create+alpha+for+phabricator+test+%E2%82%AC",
                "uri": "https://phab.mercurial-scm.org//api/differential.revision.edit",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:04 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "294"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":{\"object\":{\"id\":1190,\"phid\":\"PHID-DREV-kikesmfxhzpfaxbzgj3l\"},\"transactions\":[{\"phid\":\"PHID-XACT-DREV-od4nnssrqj57m6x\"},{\"phid\":\"PHID-XACT-DREV-2prb5lagzng6uqt\"},{\"phid\":\"PHID-XACT-DREV-qu7o6fgwssovbwb\"},{\"phid\":\"PHID-XACT-DREV-uynfy6n3u6new5f\"}]},\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "58"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "ids%5B0%5D=1190&api.token=cli-hahayouwish",
                "uri": "https://phab.mercurial-scm.org//api/differential.query",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:05 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "778"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":[{\"id\":\"1190\",\"phid\":\"PHID-DREV-kikesmfxhzpfaxbzgj3l\",\"title\":\"create alpha for phabricator test \\u20ac\",\"uri\":\"https:\\/\\/phab.mercurial-scm.org\\/D1190\",\"dateCreated\":\"1557063064\",\"dateModified\":\"1557063064\",\"authorPHID\":\"PHID-USER-qmzis76vb2yh3ogldu6r\",\"status\":\"0\",\"statusName\":\"Draft\",\"properties\":{\"draft.broadcast\":false,\"lines.added\":1,\"lines.removed\":0},\"branch\":null,\"summary\":\"\",\"testPlan\":\"\",\"lineCount\":\"1\",\"activeDiffPHID\":\"PHID-DIFF-gpg57jico75ouhl2bux2\",\"diffs\":[\"1899\"],\"commits\":[],\"reviewers\":[],\"ccs\":[],\"hashes\":[],\"auxiliary\":{\"bugzilla.bug-id\":null,\"phabricator:projects\":[\"PHID-PROJ-f2a3wl5wxtqdtfgdjqzk\"],\"phabricator:depends-on\":[]},\"repositoryPHID\":\"PHID-REPO-bvunnehri4u2isyr7bc3\",\"sourcePath\":null}],\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "296"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "diff_id=1899&data=%7B%22branch%22%3A+%22default%22%2C+%22date%22%3A+%220+0%22%2C+%22node%22%3A+%22a86ed7d85e866f01161e9f55cee5d116272f508f%22%2C+%22parent%22%3A+%220000000000000000000000000000000000000000%22%2C+%22user%22%3A+%22test%22%7D&name=hg%3Ameta&api.token=cli-hahayouwish",
                "uri": "https://phab.mercurial-scm.org//api/differential.setdiffproperty",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:06 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "51"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":null,\"error_code\":null,\"error_info\":null}"
                }
            }
        },
        {
            "request": {
                "headers": {
                    "user-agent": [
                        "mercurial/proto-1.0 (Mercurial 5.0+93-d811f17090a3+20190505)"
                    ],
                    "content-length": [
                        "257"
                    ],
                    "content-type": [
                        "application/x-www-form-urlencoded"
                    ],
                    "accept": [
                        "application/mercurial-0.1"
                    ],
                    "host": [
                        "phab.mercurial-scm.org"
                    ]
                },
                "body": "diff_id=1899&data=%7B%22a86ed7d85e866f01161e9f55cee5d116272f508f%22%3A+%7B%22author%22%3A+%22test%22%2C+%22authorEmail%22%3A+%22test%22%2C+%22branch%22%3A+%22default%22%2C+%22commit%22%3A+%22a86ed7d85e866f01161e9f55cee5d116272f508f%22%2C+%22parents%22%3A+%5B%220000000000000000000000000000000000000000%22%5D%2C+%22time%22%3A+0%7D%7D&name=local%3Acommits&api.token=cli-hahayouwish",
                "uri": "https://phab.mercurial-scm.org//api/differential.setdiffproperty",
                "method": "POST"
            },
            "response": {
                "status": {
                    "code": 200,
                    "message": "OK"
                },
                "headers": {
                    "x-xss-protection": [
                        "1; mode=block"
                    ],
                    "cache-control": [
                        "no-store"
                    ],
                    "content-type": [
                        "application/json"
                    ],
                    "date": [
                        "Sun, 05 May 2019 13:31:06 GMT"
                    ],
                    "connection": [
                        "keep-alive"
                    ],
                    "strict-transport-security": [
                        "max-age=31536000; includeSubdomains; preload"
                    ],
                    "vary": [
                        "Accept-Encoding"
                    ],
                    "x-frame-options": [
                        "Deny"
                    ],
                    "content-length": [
                        "51"
                    ],
                    "x-content-type-options": [
                        "nosniff"
                    ],
                    "expires": [
                        "Sat, 01 Jan 2000 00:00:00 GMT"
                    ]
                },
                "body": {
                    "string": "{\"result\":null,\"error_code\":null,\"error_info\":null}"
                }
            }
        }
    ]
}