tests/test-ssh-repoerror.t
author Valentin Gatien-Baron <valentin.gatienbaron@gmail.com>
Tue, 02 Jul 2019 12:59:58 -0400
changeset 42621 99ebde4fec99
parent 41420 b6673e9bdcf6
child 45906 95c4cca641f6
permissions -rw-r--r--
commit: improve the files field of changelog for merges Currently, the files list of merge commits repeats all the deletions (either actual deletions, or files that got renamed) that happened between base and p2 of the merge. If p2 is the main branch, the list can easily be much bigger than the change being merged. This results in various problems worth improving: - changelog is bigger than necessary - `hg log directory` lists many unrelated merge commits, and `hg log -v -r commit` frequently fills multiple screens worth of files - it possibly slows down adjustlinkrev, by forcing it to read more manifests, and that function can certainly be a bottleneck - the server side of pulls can waste a lot of time simply opening the filelogs for pointless files (the constant factors for opening even a tiny filelog is apparently pretty bad) So stop listing such files as described in the code. Impacted merge commits and their descendants get a different hash than they would have without this. This doesn't seem problematic, except for convert. The previous commit helped with that in the hg->hg case (but if you do svn->hg twice from scratch, hashes can still change). The rest of the description is numbers. I don't have much to report, because recreating the files list of existing repositories is not easy: - debugupgradeformat and bundle/unbundle don't recreate the list - export/import tends to choke quickly applying patches or on description that contain diffs, - merge commits from the convert extension don't have the right files list for reasons orthogonal to the current commit - replaying the merge with hg update/hg merge/hg revert --all/hg commit can end up failing in hg revert - I wasn't sure that using debugsetparents + debugrebuilddirstate would really build the right thing I measured commit time before and after this change, in a case with no files filtered out, several files filtered out (no difference) and 5k files filtered out (+1% time). Recreating the 100 more recent merges in a private repo, the concatenated uncompressed files lists goes from 1.12MB to 0.52MB. Excluding 3 merges that are not representative, then the size goes from 570k to 15k. I converted part of mozilla-central, and observed file list shrinking quite a bit too, starting at the very first merge, 733641d9feaf, going from 550 files to 10 files (although they have relatively few merges, so they probably wouldn't care). Differential Revision: https://phab.mercurial-scm.org/D6613
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
39382
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     1
#require unix-permissions no-root
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     2
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     3
initial setup
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     4
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     5
  $ cat << EOF >> $HGRCPATH
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     6
  > [ui]
39707
5abc47d4ca6b tests: quote PYTHON usage
Matt Harbison <matt_harbison@yahoo.com>
parents: 39382
diff changeset
     7
  > ssh="$PYTHON" "$TESTDIR/dummyssh"
39382
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     8
  > EOF
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
     9
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    10
repository itself is non-readable
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    11
---------------------------------
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    12
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    13
  $ hg init no-read
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    14
  $ hg id ssh://user@dummy/no-read
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    15
  000000000000
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    16
  $ chmod a-rx no-read
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    17
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    18
  $ hg id ssh://user@dummy/no-read
40227
f4893b59230f py3: more globing of things to make output compatible between py2 and py3
Pulkit Goyal <pulkit@yandex-team.ru>
parents: 39707
diff changeset
    19
  remote: abort: Permission denied: *$TESTTMP/no-read/.hg* (glob)
39382
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    20
  abort: no suitable response from remote hg!
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    21
  [255]
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    22
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    23
special case files are visible, but unreadable
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    24
----------------------------------------------
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    25
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    26
This is "similar" to the test above, but the directory is "traversable". This
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    27
seems an unexpected case in real life, but we test it anyway.
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    28
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    29
  $ hg init other
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    30
  $ hg id ssh://user@dummy/other
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    31
  000000000000
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    32
  $ for item in `find other | sort -r` ; do
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    33
  >     chmod a-r $item
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    34
  > done
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    35
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    36
  $ hg id ssh://user@dummy/other
41420
b6673e9bdcf6 dispatch: quote filename in IOError as well
Yuya Nishihara <yuya@tcha.org>
parents: 40227
diff changeset
    37
  remote: abort: Permission denied: '$TESTTMP/other/.hg/requires'
39382
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    38
  abort: no suitable response from remote hg!
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    39
  [255]
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    40
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    41
directory toward the repository is read only
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    42
--------------------------------------------
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    43
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    44
  $ mkdir deep
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    45
  $ hg init deep/nested
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    46
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    47
  $ hg id ssh://user@dummy/deep/nested
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    48
  000000000000
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    49
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    50
  $ chmod a-rx deep
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    51
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    52
  $ hg id ssh://user@dummy/deep/nested
40227
f4893b59230f py3: more globing of things to make output compatible between py2 and py3
Pulkit Goyal <pulkit@yandex-team.ru>
parents: 39707
diff changeset
    53
  remote: abort: Permission denied: *$TESTTMP/deep/nested/.hg* (glob)
39382
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    54
  abort: no suitable response from remote hg!
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    55
  [255]
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    56
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    57
repository has wrong requirement
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    58
--------------------------------
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    59
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    60
  $ hg init repo-future
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    61
  $ hg id ssh://user@dummy/repo-future
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    62
  000000000000
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    63
  $ echo flying-car >> repo-future/.hg/requires
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    64
  $ hg id ssh://user@dummy/repo-future
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    65
  remote: abort: repository requires features unknown to this Mercurial: flying-car!
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    66
  remote: (see https://mercurial-scm.org/wiki/MissingRequirement for more information)
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    67
  abort: no suitable response from remote hg!
a7e22dd31f54 test: add a test file that displays ssh behavior in front of various errors
Boris Feld <boris.feld@octobus.net>
parents:
diff changeset
    68
  [255]