Mercurial > hg
annotate tests/test-hg-parseurl.py.out @ 18759:9baf4330d88f
sshpeer: store subprocess so it cleans up correctly
When running 'hg pull --rebase', I was seeing this exception 100% of the
time as the python process was closing down:
Exception TypeError: TypeError("'NoneType' object is not callable",) in
<bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored
By storing the subprocess on the sshpeer, the subprocess seems to clean up
correctly, and I no longer see the exception. I have no idea why this actually
works, but I get a 0% repro if I store the subprocess in self.subprocess,
and a 100% repro if I store None in self.subprocess.
Possibly related to issue 2240.
author | Durham Goode <durham@fb.com> |
---|---|
date | Fri, 08 Mar 2013 16:59:36 -0800 |
parents | 375872fdadba |
children |
rev | line source |
---|---|
11322
3d6915f5a2bb
improve --branch processing (and differentiate from # syntax)
Sune Foldager <cryo@cyanite.org>
parents:
10365
diff
changeset
|
1 http://example.com/no/anchor, branches: (None, []) |
3d6915f5a2bb
improve --branch processing (and differentiate from # syntax)
Sune Foldager <cryo@cyanite.org>
parents:
10365
diff
changeset
|
2 http://example.com/an/anchor, branches: ('foo', []) |
3d6915f5a2bb
improve --branch processing (and differentiate from # syntax)
Sune Foldager <cryo@cyanite.org>
parents:
10365
diff
changeset
|
3 http://example.com/no/anchor/branches, branches: (None, ['foo']) |
3d6915f5a2bb
improve --branch processing (and differentiate from # syntax)
Sune Foldager <cryo@cyanite.org>
parents:
10365
diff
changeset
|
4 http://example.com/an/anchor/branches, branches: ('bar', ['foo']) |
3d6915f5a2bb
improve --branch processing (and differentiate from # syntax)
Sune Foldager <cryo@cyanite.org>
parents:
10365
diff
changeset
|
5 http://example.com/an/anchor/branches-None, branches: ('foo', []) |
13897
375872fdadba
hg: make parseurl() consistently return normalised path
Thomas Arendsen Hein <thomas@intevation.de>
parents:
11322
diff
changeset
|
6 http://example.com/, branches: (None, []) |
375872fdadba
hg: make parseurl() consistently return normalised path
Thomas Arendsen Hein <thomas@intevation.de>
parents:
11322
diff
changeset
|
7 http://example.com/, branches: (None, []) |
375872fdadba
hg: make parseurl() consistently return normalised path
Thomas Arendsen Hein <thomas@intevation.de>
parents:
11322
diff
changeset
|
8 http://example.com/, branches: ('foo', []) |