Mercurial > hg
annotate tests/test-check-execute.t @ 44943:9e5b4dbe8ff2
localrepo: handle ValueError during repository opening
Python 3.8 can raise ValueError on attempt of an I/O operation
against an illegal path. This was causing test-remotefilelog-gc.t
to fail on Python 3.8.
This commit teaches repository opening to handle ValueError
and re-raise an Abort on failure.
An arguably better solution would be to implement this logic
in the vfs layer. But that seems like a bag of worms and I don't
want to go down that rabbit hole. Until users report uncaught
ValueError exceptions in the wild, I think it is fine to patch
this at the only occurrence our test harness is finding it.
Differential Revision: https://phab.mercurial-scm.org/D7944
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Sat, 18 Jan 2020 10:07:07 -0800 |
parents | ddd65b4f3ae6 |
children | fb6593307e24 |
rev | line source |
---|---|
27569 | 1 #require test-repo execbit |
2 | |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
27569 | 4 $ cd "`dirname "$TESTDIR"`" |
5 | |
6 look for python scripts without the execute bit | |
7 | |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
8 $ testrepohg files 'set:**.py and not exec() and grep(r"^#!.*?python")' |
27569 | 9 [1] |
10 | |
11 look for python scripts with execute bit but not shebang | |
12 | |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
13 $ testrepohg files 'set:**.py and exec() and not grep(r"^#!.*?python")' |
27569 | 14 [1] |
15 | |
16 look for shell scripts with execute bit but not shebang | |
17 | |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
18 $ testrepohg files 'set:**.sh and exec() and not grep(r"^#!.*(ba)?sh")' |
27569 | 19 [1] |
20 | |
21 look for non scripts with no shebang | |
22 | |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
23 $ testrepohg files 'set:exec() and not **.sh and not **.py and not grep(r"^#!")' |
27569 | 24 [1] |