Mercurial Mercurial > hg / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
CONTRIBUTING
author Martijn Pieters <mjpieters@fb.com>
Sun, 09 Oct 2016 14:10:01 +0200
changeset 30118 c19266edd93e
parent 30084 a492610a2fc1
permissions -rw-r--r--
py3: a second argument to open can't be bytes This fixes open(filename, 'r'), open(filename, 'w'), etc. calls. In Python 3, that second argument *must* be a string, you can't use bytes. The fix is the same as used with getattr() (where the second argument must also always be a string); in the tokenizer, where we detect calls, if there is something that looks like a call to open (and is not an attribute, so the previous token is not a "." dot) then make sure that that second argument is not converted to a `bytes` object instead. There is some remaining issue where the current transformer will also rewrite open(f('foo')). However this also affect function for which we perform similar rewrite ('getattr', 'setattr', 'hasattr', 'safehasattr') and will be dealt with in a follow up.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
30084
a492610a2fc1 contributing: add new file with a pointer to the wiki
Augie Fackler <augie@google.com>
parents:
diff changeset 
     1
 
Our full contribution guidelines are in our wiki, please see:
a492610a2fc1 contributing: add new file with a pointer to the wiki
Augie Fackler <augie@google.com>
parents:
diff changeset 
     2
 












a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     3


https://www.mercurial-scm.org/wiki/ContributingChanges













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     4














a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     5


If you just want a checklist to follow, you can go straight to













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     6














a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     7


https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     8














a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




     9


If you can't run the entire testsuite for some reason (it can be













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




    10


difficult on Windows), please at least run `contrib/check-code.py` on













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




    11


any files you've modified and run `python contrib/check-commit` on any













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




    12


commits you've made (for example, `python contrib/check-commit













a492610a2fc1
contributing: add new file with a pointer to the wiki



Augie Fackler <augie@google.com>


parents: 

diff
changeset




    13


273ce12ad8f1` will report some style violations on a very old commit).















Mercurial