Mercurial > hg
annotate tests/test-check-pyflakes.t @ 39561:d06834e0f48e
wireprotov2peer: stream decoded responses
Previously, wire protocol version 2 would buffer all response data.
Only once all data was received did we CBOR decode it and resolve
the future associated with the command. This was obviously not
desirable. In future commits that introduce large response payloads,
this caused significant memory bloat and slowed down client
operations due to waiting on the server.
This commit refactors the response handling code so that response
data can be streamed.
Command response objects now contain a buffered CBOR decoder. As
new data arrives, it is fed into the decoder. Decoded objects are
made available to the generator as they are decoded.
Because there is a separate thread processing incoming frames and
feeding data into the response object, there is the potential for
race conditions when mutating response objects. So a lock has been
added to guard access to critical state variables.
Because the generator emitting decoded objects needs to wait on
those objects to become available, we've added an Event for the
generator to wait on so it doesn't busy loop. This does mean
there is the potential for deadlocks. And I'm pretty sure they can
occur in some scenarios. We already have a handful of TODOs around
this. But I've added some more. Fixing this will likely require
moving the background thread receiving frames into clienthandler.
We likely would have done this anyway when implementing the client
bits for the SSH transport.
Test output changes because the initial CBOR map holding the overall
response state is now always handled internally by the response
object.
Differential Revision: https://phab.mercurial-scm.org/D4474
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Wed, 29 Aug 2018 15:17:11 -0700 |
parents | 3ccaf995f549 |
children | 094d0f4a8edd |
rev | line source |
---|---|
29138
a29f071751df
tests: mark test-check-pyflakes.t as requiring hg1.0+
timeless <timeless@mozdev.org>
parents:
27285
diff
changeset
|
1 #require test-repo pyflakes hg10 |
21208
0e1cbd3d52f7
tests: add repository check for pyflakes test
Matt Mackall <mpm@selenic.com>
parents:
20644
diff
changeset
|
2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
29138
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
19377
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
4 |
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
5 run pyflakes on all tracked files ending in .py or without a file ending |
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
6 (skipping binary file random-seed) |
21208
0e1cbd3d52f7
tests: add repository check for pyflakes test
Matt Mackall <mpm@selenic.com>
parents:
20644
diff
changeset
|
7 |
33367
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
8 $ cat > test.py <<EOF |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
9 > print(undefinedname) |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
10 > EOF |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
11 $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
12 test.py:1: undefined name 'undefinedname' |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
13 |
33418
1f3b54f392b0
test-check-pyflakes: do not leave test.py in the repo
Jun Wu <quark@fb.com>
parents:
33367
diff
changeset
|
14 $ cd "`dirname "$TESTDIR"`" |
33367
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
15 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
16 $ testrepohg locate 'set:**.py or grep("^#!.*python")' \ |
33116
6c113a7dec52
tests: use the system hg for examining the local repository
Adam Simpkins <simpkins@fb.com>
parents:
32510
diff
changeset
|
17 > -X hgext/fsmonitor/pywatchman \ |
30894
5b60464efbde
tests: exclude python-zstandard from pyflakes analysis
Augie Fackler <augie@google.com>
parents:
30655
diff
changeset
|
18 > -X mercurial/pycompat.py -X contrib/python-zstandard \ |
37127
0e06d8086295
cbor: fix core test-check*
Pulkit Goyal <7895pulkit@gmail.com>
parents:
33418
diff
changeset
|
19 > -X mercurial/thirdparty/cbor \ |
37625
3ccaf995f549
tests: silence pyflakes for thirdparty/concurrent
Gregory Szorc <gregory.szorc@gmail.com>
parents:
37182
diff
changeset
|
20 > -X mercurial/thirdparty/concurrent \ |
37182
559069689121
tests: ignore zope packages when running pyflakes
Gregory Szorc <gregory.szorc@gmail.com>
parents:
37127
diff
changeset
|
21 > -X mercurial/thirdparty/zope \ |
29584
06587edd1233
pycompat: make pycompat demandimport friendly
Pulkit Goyal <7895pulkit@gmail.com>
parents:
29232
diff
changeset
|
22 > 2>/dev/null \ |
19377
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
23 > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" |
22053
4354b1e35f53
tests: fix pyflakes test whitespace breakage
Matt Mackall <mpm@selenic.com>
parents:
22047
diff
changeset
|
24 |