Mercurial > hg
annotate tests/test-config-case.t @ 14007:d764463b433e
atomictempfile: avoid infinite recursion in __del__().
The problem is that a programmer using atomictempfile directly can
make an innocent everyday mistake -- not enough args to the
constructor -- which escalates badly. You would expect a simple
TypeError crash in that case, but you actually get an infinite
recursion that is surprisingly difficult to kill: it happens between
__del__() and __getattr__(), and Python does not handle infinite
recursion from __del__() well.
The fix is to not implement __getattr__(), but instead assign instance
attributes for the methods we wish to delegate to the builtin file
type: write() and fileno(). I've audited mercurial.* and hgext.* and
found no users of atomictempfile using methods other than write() and
rename(). I audited third-party extensions and found one (snap)
passing an atomictempfile to util.fstat(), so I also threw in
fileno().
The last time I submitted a similar patch, Matt proposed that we make
atomictempfile a subclass of file instead of wrapping it. Rejected on
grounds of unnecessary complexity: for one thing, it would make the
Windows implementation of posixfile quite a bit more complex. It would
have to become a subclass of file rather than a simple function -- but
since it's written in C, this is non-obvious and non-trivial.
Furthermore, there's nothing wrong with wrapping objects and
delegating methods: it's a well-established pattern that works just
fine in many cases. Subclassing is not the answer to all of life's
problems.
author | Greg Ward <greg@gerg.ca> |
---|---|
date | Sun, 24 Apr 2011 19:25:10 -0400 |
parents | 5e2216a35839 |
children | 73d20de5f30b |
rev | line source |
---|---|
12082
5e2216a35839
tests: unify test-config-case
Adrian Buehlmann <adrian@cadifra.com>
parents:
4528
diff
changeset
|
1 $ echo '[Section]' >> $HGRCPATH |
5e2216a35839
tests: unify test-config-case
Adrian Buehlmann <adrian@cadifra.com>
parents:
4528
diff
changeset
|
2 $ echo 'KeY = Case Sensitive' >> $HGRCPATH |
5e2216a35839
tests: unify test-config-case
Adrian Buehlmann <adrian@cadifra.com>
parents:
4528
diff
changeset
|
3 $ echo 'key = lower case' >> $HGRCPATH |
3425
ec6f400cff4d
Use a case-sensitive version of SafeConfigParser everywhere
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
4 |
12082
5e2216a35839
tests: unify test-config-case
Adrian Buehlmann <adrian@cadifra.com>
parents:
4528
diff
changeset
|
5 $ hg showconfig Section |
5e2216a35839
tests: unify test-config-case
Adrian Buehlmann <adrian@cadifra.com>
parents:
4528
diff
changeset
|
6 Section.KeY=Case Sensitive |
5e2216a35839
tests: unify test-config-case
Adrian Buehlmann <adrian@cadifra.com>
parents:
4528
diff
changeset
|
7 Section.key=lower case |
3425
ec6f400cff4d
Use a case-sensitive version of SafeConfigParser everywhere
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
8 |