Mercurial > hg
annotate tests/test-profile.t @ 14007:d764463b433e
atomictempfile: avoid infinite recursion in __del__().
The problem is that a programmer using atomictempfile directly can
make an innocent everyday mistake -- not enough args to the
constructor -- which escalates badly. You would expect a simple
TypeError crash in that case, but you actually get an infinite
recursion that is surprisingly difficult to kill: it happens between
__del__() and __getattr__(), and Python does not handle infinite
recursion from __del__() well.
The fix is to not implement __getattr__(), but instead assign instance
attributes for the methods we wish to delegate to the builtin file
type: write() and fileno(). I've audited mercurial.* and hgext.* and
found no users of atomictempfile using methods other than write() and
rename(). I audited third-party extensions and found one (snap)
passing an atomictempfile to util.fstat(), so I also threw in
fileno().
The last time I submitted a similar patch, Matt proposed that we make
atomictempfile a subclass of file instead of wrapping it. Rejected on
grounds of unnecessary complexity: for one thing, it would make the
Windows implementation of posixfile quite a bit more complex. It would
have to become a subclass of file rather than a simple function -- but
since it's written in C, this is non-obvious and non-trivial.
Furthermore, there's nothing wrong with wrapping objects and
delegating methods: it's a well-established pattern that works just
fine in many cases. Subclassing is not the answer to all of life's
problems.
author | Greg Ward <greg@gerg.ca> |
---|---|
date | Sun, 24 Apr 2011 19:25:10 -0400 |
parents | bb665db49e32 |
children | bb91c602d4ad |
rev | line source |
---|---|
12478 | 1 test --time |
5099
105d4cf7ec24
Test --time, --profile and --lsprof
Patrick Mezard <pmezard@gmail.com>
parents:
diff
changeset
|
2 |
12478 | 3 $ hg --time help -q help 2>&1 | grep Time > /dev/null |
4 $ hg init a | |
5 $ cd a | |
8022
4f3fdfaa3874
profiling: Adding profiling.output config variable
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
8021
diff
changeset
|
6 |
12478 | 7 test --profile |
8022
4f3fdfaa3874
profiling: Adding profiling.output config variable
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
8021
diff
changeset
|
8 |
12478 | 9 $ if "$TESTDIR/hghave" -q lsprof; then |
10 > hg --profile st 2>../out || echo --profile failed | |
11 > grep CallCount < ../out > /dev/null || echo wrong --profile | |
12 > | |
13 > hg --profile --config profiling.output=../out st 2>&1 \ | |
14 > || echo --profile + output to file failed | |
15 > grep CallCount < ../out > /dev/null \ | |
16 > || echo wrong --profile output when saving to a file | |
17 > | |
18 > hg --profile --config profiling.format=text st 2>&1 \ | |
19 > | grep CallCount > /dev/null || echo --profile format=text failed | |
20 > | |
21 > echo "[profiling]" >> $HGRCPATH | |
22 > echo "format=kcachegrind" >> $HGRCPATH | |
23 > | |
24 > hg --profile st 2>../out || echo --profile format=kcachegrind failed | |
25 > grep 'events: Ticks' < ../out > /dev/null || echo --profile output is wrong | |
26 > | |
27 > hg --profile --config profiling.output=../out st 2>&1 \ | |
28 > || echo --profile format=kcachegrind + output to file failed | |
29 > grep 'events: Ticks' < ../out > /dev/null \ | |
30 > || echo --profile output is wrong | |
31 > fi |