Mercurial > hg
annotate tests/test-remove-new.t @ 14007:d764463b433e
atomictempfile: avoid infinite recursion in __del__().
The problem is that a programmer using atomictempfile directly can
make an innocent everyday mistake -- not enough args to the
constructor -- which escalates badly. You would expect a simple
TypeError crash in that case, but you actually get an infinite
recursion that is surprisingly difficult to kill: it happens between
__del__() and __getattr__(), and Python does not handle infinite
recursion from __del__() well.
The fix is to not implement __getattr__(), but instead assign instance
attributes for the methods we wish to delegate to the builtin file
type: write() and fileno(). I've audited mercurial.* and hgext.* and
found no users of atomictempfile using methods other than write() and
rename(). I audited third-party extensions and found one (snap)
passing an atomictempfile to util.fstat(), so I also threw in
fileno().
The last time I submitted a similar patch, Matt proposed that we make
atomictempfile a subclass of file instead of wrapping it. Rejected on
grounds of unnecessary complexity: for one thing, it would make the
Windows implementation of posixfile quite a bit more complex. It would
have to become a subclass of file rather than a simple function -- but
since it's written in C, this is non-obvious and non-trivial.
Furthermore, there's nothing wrong with wrapping objects and
delegating methods: it's a well-established pattern that works just
fine in many cases. Subclassing is not the answer to all of life's
problems.
author | Greg Ward <greg@gerg.ca> |
---|---|
date | Sun, 24 Apr 2011 19:25:10 -0400 |
parents | 92e30e135581 |
children |
rev | line source |
---|---|
12100
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
1 test that 'hg commit' does not crash if the user removes a newly added file |
11346
e740f36cfb4b
tests: rename test-merge3 to test-add-remove.
Greg Ward <greg-hg@gerg.ca>
parents:
11177
diff
changeset
|
2 |
12100
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
3 $ hg init |
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
4 $ echo This is file a1 > a |
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
5 $ hg add a |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12100
diff
changeset
|
6 $ hg commit -m "commit #0" |
12100
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
7 $ touch b |
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
8 $ hg add b |
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
9 $ rm b |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12100
diff
changeset
|
10 $ hg commit -A -m"comment #1" |
12100
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
11 removing b |
4d6bb7615564
tests: unify test-remove-new
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
11346
diff
changeset
|
12 nothing changed |
12316
4134686b83e1
tests: add exit codes to unified tests
Matt Mackall <mpm@selenic.com>
parents:
12156
diff
changeset
|
13 [1] |