tests/test-check-pylint.t
author Matt Harbison <matt_harbison@yahoo.com>
Wed, 11 Apr 2018 17:29:55 -0400
changeset 37562 e5cd8d1a094d
parent 35630 6061e54ff81d
child 38180 6ae62d62c3f6
permissions -rw-r--r--
lfs: special case the null:// usercache instead of treating it as a url The previous code worked on Windows, but not on Unix, and a pending patch's test failed. The url being used was something like "/tmp/.../client1/null://", courtesy of ui.configpath(). Looking at the doc comment, this seems like it's maybe not the right function to call (why should a relative cache path be expanded relative to the repo root or config file?), but largefiles has been using it since 8b8dd13295db (Oct 2011). It was introduced in 1b591f9b7fd2 (Jan 2011) without comment or callers. A grep over the whole history shows that only largefiles used it until lfs and infinitepush came along recently. It looks like if the `if not os.path.isabs(v) or "://" not in v` in configpath() is changed to an 'and', both Linux and Windows are happy. I'm guessing that "://" is to pick off URLs, so that seems reasonable. But I'm not sure why it isn't explicitly "file://", and I thought that "file://foo" is relative anyway. (At least, there are doctests for file:///tmp in util.url.) There is no mention of this setting in the help, but it is referenced on the wiki page for largefiles. (There's no mention that this is intended to be a URL, and the example uses an absolute path.) I don't want this blocking the rest of the lfs server discovery stuff. It was also wrong to allow a file:// URL here, but not in largefiles.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
31413
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     1
#require test-repo pylint hg10
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     2
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     3
Run pylint for known rules we care about.
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     4
-----------------------------------------
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     5
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     6
There should be no recorded failures; fix the codebase before introducing a
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     7
new check.
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     8
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
     9
Current checks:
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    10
- W0102: no mutable default argument
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    11
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    12
  $ touch $TESTTMP/fakerc
aa797bd54f44 test: add a basic 'test-check-pylint.t'
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
diff changeset
    13
  $ pylint --rcfile=$TESTTMP/fakerc --disable=all \
35630
6061e54ff81d pylint: add a check for multiple statement on a single line
Boris Feld <boris.feld@octobus.net>
parents: 35627
diff changeset
    14
  >   --enable=W0102,C0321 \
35627
882998f08c3c pylint: split command line argument on multiple lines
Boris Feld <boris.feld@octobus.net>
parents: 34395
diff changeset
    15
  >   --reports=no \
34395
41401f502c83 tests: disable lints on mercurial/thirdparty
Siddharth Agarwal <sid0@fb.com>
parents: 32421
diff changeset
    16
  >   --ignore=thirdparty \
32421
778dc37ce683 check: check modules in hgdemandimport
Siddharth Agarwal <sid0@fb.com>
parents: 31839
diff changeset
    17
  >   mercurial hgdemandimport hgext hgext3rd
31839
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31413
diff changeset
    18
   (?)
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31413
diff changeset
    19
  ------------------------------------ (?)
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31413
diff changeset
    20
  Your code has been rated at 10.00/10 (?)
5b048d5f8884 test-check-pylint: match its output
Jun Wu <quark@fb.com>
parents: 31413
diff changeset
    21
   (?)