author | Martin Geisler <mg@aragost.com> |
Tue, 15 Jun 2010 09:55:59 +0200 | |
changeset 11343 | f325db39c8b9 |
parent 11341 | 920a783e5f91 |
child 11345 | 4b81f82b03e3 |
permissions | -rwxr-xr-x |
10281 | 1 |
#!/usr/bin/env python |
2 |
# |
|
3 |
# check-code - a style and portability checker for Mercurial |
|
4 |
# |
|
10290
7cc60de189d7
check-code: fix copyright date
Matt Mackall <mpm@selenic.com>
parents:
10287
diff
changeset
|
5 |
# Copyright 2010 Matt Mackall <mpm@selenic.com> |
10281 | 6 |
# |
7 |
# This software may be used and distributed according to the terms of the |
|
8 |
# GNU General Public License version 2 or any later version. |
|
9 |
||
10905
13a1b2fb7ef2
pylint, pyflakes: remove unused or duplicate imports
Nicolas Dumazet <nicdumz.commits@gmail.com>
parents:
10895
diff
changeset
|
10 |
import re, glob |
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
11 |
import optparse |
10281 | 12 |
|
13 |
def repquote(m): |
|
10722
c4fb2103e734
check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10720
diff
changeset
|
14 |
t = re.sub(r"\w", "x", m.group('text')) |
10451
63a9bfad50ff
check-code: two more rules
Matt Mackall <mpm@selenic.com>
parents:
10412
diff
changeset
|
15 |
t = re.sub(r"[^\sx]", "o", t) |
10722
c4fb2103e734
check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10720
diff
changeset
|
16 |
return m.group('quote') + t + m.group('quote') |
10281 | 17 |
|
10727
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
18 |
def reppython(m): |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
19 |
comment = m.group('comment') |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
20 |
if comment: |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
21 |
return "#" * len(comment) |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
22 |
return repquote(m) |
10281 | 23 |
|
24 |
def repcomment(m): |
|
25 |
return m.group(1) + "#" * len(m.group(2)) |
|
26 |
||
27 |
def repccomment(m): |
|
28 |
t = re.sub(r"((?<=\n) )|\S", "x", m.group(2)) |
|
29 |
return m.group(1) + t + "*/" |
|
30 |
||
31 |
def repcallspaces(m): |
|
32 |
t = re.sub(r"\n\s+", "\n", m.group(2)) |
|
33 |
return m.group(1) + t |
|
34 |
||
35 |
def repinclude(m): |
|
36 |
return m.group(1) + "<foo>" |
|
37 |
||
38 |
def rephere(m): |
|
39 |
t = re.sub(r"\S", "x", m.group(2)) |
|
40 |
return m.group(1) + t |
|
41 |
||
42 |
||
43 |
testpats = [ |
|
10374
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
44 |
(r'(pushd|popd)', "don't use 'pushd' or 'popd', use 'cd'"), |
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
45 |
(r'\W\$?\(\([^\)]*\)\)', "don't use (()) or $(()), use 'expr'"), |
10281 | 46 |
(r'^function', "don't use 'function', use old style"), |
10374
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
47 |
(r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), |
10373
e4c7972002e4
check-code.py: escape backslash
Mads Kiilerich <mads@kiilerich.com>
parents:
10291
diff
changeset
|
48 |
(r'echo.*\\n', "don't use 'echo \\n', use printf"), |
10374
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
49 |
(r'^diff.*-\w*N', "don't use 'diff -N'"), |
10281 | 50 |
(r'(^| )wc[^|]*$', "filter wc output"), |
10374
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
51 |
(r'head -c', "don't use 'head -c', use 'dd'"), |
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
52 |
(r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), |
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
53 |
(r'printf.*\\\d\d\d', "don't use 'printf \NNN', use Python"), |
3aa35db5e38c
check-code.py: make help strings consistent
Martin Geisler <mg@lazybytes.net>
parents:
10373
diff
changeset
|
54 |
(r'printf.*\\x', "don't use printf \\x, use Python"), |
10281 | 55 |
(r'\$\(.*\)', "don't use $(expr), use `expr`"), |
56 |
(r'rm -rf \*', "don't use naked rm -rf, target a directory"), |
|
57 |
(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', |
|
58 |
"use egrep for extended grep syntax"), |
|
59 |
(r'/bin/', "don't use explicit paths for tools"), |
|
60 |
(r'\$PWD', "don't use $PWD, use `pwd`"), |
|
61 |
(r'[^\n]\Z', "no trailing newline"), |
|
10658
95c7c4b7e67a
test-merge-default and check-code.py: No "export x=x" in sh
Mads Kiilerich <mads@kiilerich.com>
parents:
10451
diff
changeset
|
62 |
(r'export.*=', "don't export and assign at once"), |
10802
6e4cf8319f54
check-code.py: Check for bare ^
Mads Kiilerich <mads@kiilerich.com>
parents:
10658
diff
changeset
|
63 |
('^([^"\']|("[^"]*")|(\'[^\']*\'))*\\^', "^ must be quoted"), |
11210
0c0088881562
check-code: add check for 'source'
Yuya Nishihara <yuya@tcha.org>
parents:
10905
diff
changeset
|
64 |
(r'^source\b', "don't use 'source', use '.'"), |
10281 | 65 |
] |
66 |
||
67 |
testfilters = [ |
|
68 |
(r"( *)(#([^\n]*\S)?)", repcomment), |
|
69 |
(r"<<(\S+)((.|\n)*?\n\1)", rephere), |
|
70 |
] |
|
71 |
||
72 |
pypats = [ |
|
73 |
(r'^\s*\t', "don't use tabs"), |
|
10412
5326800d6937
check-code: import some pylint checks
Matt Mackall <mpm@selenic.com>
parents:
10374
diff
changeset
|
74 |
(r'\S;\s*\n', "semicolon"), |
10281 | 75 |
(r'\w,\w', "missing whitespace after ,"), |
76 |
(r'\w[+/*\-<>]\w', "missing whitespace in expression"), |
|
77 |
(r'^\s+\w+=\w+[^,)]$', "missing whitespace in assignment"), |
|
78 |
(r'.{85}', "line too long"), |
|
79 |
(r'[^\n]\Z', "no trailing newline"), |
|
80 |
# (r'^\s+[^_ ][^_. ]+_[^_]+\s*=', "don't use underbars in identifiers"), |
|
81 |
# (r'\w*[a-z][A-Z]\w*\s*=', "don't use camelcase in identifiers"), |
|
10286 | 82 |
(r'^\s*(if|while|def|class|except|try)\s[^[]*:\s*[^\]#\s]+', |
83 |
"linebreak after :"), |
|
10281 | 84 |
(r'class\s[^(]:', "old-style class, use class foo(object)"), |
10291
61c93743fae0
check-code: del isn't a function
Matt Mackall <mpm@selenic.com>
parents:
10290
diff
changeset
|
85 |
(r'^\s+del\(', "del isn't a function"), |
10281 | 86 |
(r'^\s+except\(', "except isn't a function"), |
10412
5326800d6937
check-code: import some pylint checks
Matt Mackall <mpm@selenic.com>
parents:
10374
diff
changeset
|
87 |
(r',]', "unneeded trailing ',' in list"), |
10281 | 88 |
# (r'class\s[A-Z][^\(]*\((?!Exception)', |
89 |
# "don't capitalize non-exception classes"), |
|
90 |
# (r'in range\(', "use xrange"), |
|
91 |
# (r'^\s*print\s+', "avoid using print in core and extensions"), |
|
92 |
(r'[\x80-\xff]', "non-ASCII character literal"), |
|
93 |
(r'("\')\.format\(', "str.format() not available in Python 2.4"), |
|
94 |
(r'^\s*with\s+', "with not available in Python 2.4"), |
|
11343
f325db39c8b9
check-code: catch format(), introduced in Python 2.6
Martin Geisler <mg@aragost.com>
parents:
11341
diff
changeset
|
95 |
(r'(?<!def)\s+(any|all|format)\(', "any/all/format not available in Python 2.4"), |
10281 | 96 |
(r'if\s.*\selse', "if ... else form not available in Python 2.4"), |
97 |
(r'([\(\[]\s\S)|(\S\s[\)\]])', "gratuitous whitespace in () or []"), |
|
98 |
# (r'\s\s=', "gratuitous whitespace before ="), |
|
10412
5326800d6937
check-code: import some pylint checks
Matt Mackall <mpm@selenic.com>
parents:
10374
diff
changeset
|
99 |
(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=)\S', "missing whitespace around operator"), |
5326800d6937
check-code: import some pylint checks
Matt Mackall <mpm@selenic.com>
parents:
10374
diff
changeset
|
100 |
(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=)\s', "missing whitespace around operator"), |
5326800d6937
check-code: import some pylint checks
Matt Mackall <mpm@selenic.com>
parents:
10374
diff
changeset
|
101 |
(r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=)\S', "missing whitespace around operator"), |
5326800d6937
check-code: import some pylint checks
Matt Mackall <mpm@selenic.com>
parents:
10374
diff
changeset
|
102 |
(r'[^+=*!<>&| -](\s=|=\s)[^= ]', "wrong whitespace around ="), |
10451
63a9bfad50ff
check-code: two more rules
Matt Mackall <mpm@selenic.com>
parents:
10412
diff
changeset
|
103 |
(r'raise Exception', "don't raise generic exceptions"), |
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
104 |
(r'ui\.(status|progress|write|note)\([\'\"]x', |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
105 |
"warning: unwrapped ui message"), |
10281 | 106 |
] |
107 |
||
108 |
pyfilters = [ |
|
10727
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
109 |
(r"""(?msx)(?P<comment>\#.*?$)| |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
110 |
((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!"))) |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
111 |
(?P<text>(([^\\]|\\.)*?)) |
62b8f15683f2
check-code: more tests and more robust python filtering
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10723
diff
changeset
|
112 |
(?P=quote))""", reppython), |
10281 | 113 |
] |
114 |
||
115 |
cpats = [ |
|
116 |
(r'//', "don't use //-style comments"), |
|
117 |
(r'^ ', "don't use spaces to indent"), |
|
118 |
(r'\S\t', "don't use tabs except for indent"), |
|
119 |
(r'(\S\s+|^\s+)\n', "trailing whitespace"), |
|
120 |
(r'.{85}', "line too long"), |
|
121 |
(r'(while|if|do|for)\(', "use space after while/if/do/for"), |
|
122 |
(r'return\(', "return is not a function"), |
|
123 |
(r' ;', "no space before ;"), |
|
124 |
(r'\w+\* \w+', "use int *foo, not int* foo"), |
|
125 |
(r'\([^\)]+\) \w+', "use (int)foo, not (int) foo"), |
|
126 |
(r'\S+ (\+\+|--)', "use foo++, not foo ++"), |
|
127 |
(r'\w,\w', "missing whitespace after ,"), |
|
128 |
(r'\w[+/*]\w', "missing whitespace in expression"), |
|
129 |
(r'^#\s+\w', "use #foo, not # foo"), |
|
130 |
(r'[^\n]\Z', "no trailing newline"), |
|
131 |
] |
|
132 |
||
133 |
cfilters = [ |
|
134 |
(r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment), |
|
10722
c4fb2103e734
check-code: improve quote detection regexp, add tests
Benoit Boissinot <benoit.boissinot@ens-lyon.org>
parents:
10720
diff
changeset
|
135 |
(r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote), |
10281 | 136 |
(r'''(#\s*include\s+<)([^>]+)>''', repinclude), |
137 |
(r'(\()([^)]+\))', repcallspaces), |
|
138 |
] |
|
139 |
||
140 |
checks = [ |
|
141 |
('python', r'.*\.(py|cgi)$', pyfilters, pypats), |
|
142 |
('test script', r'(.*/)?test-[^.~]*$', testfilters, testpats), |
|
143 |
('c', r'.*\.c$', cfilters, cpats), |
|
144 |
] |
|
145 |
||
10719
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
146 |
class norepeatlogger(object): |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
147 |
def __init__(self): |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
148 |
self._lastseen = None |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
149 |
|
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
150 |
def log(self, fname, lineno, line, msg): |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
151 |
"""print error related a to given line of a given file. |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
152 |
|
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
153 |
The faulty line will also be printed but only once in the case |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
154 |
of multiple errors. |
10281 | 155 |
|
10719
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
156 |
:fname: filename |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
157 |
:lineno: line number |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
158 |
:line: actual content of the line |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
159 |
:msg: error message |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
160 |
""" |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
161 |
msgid = fname, lineno, line |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
162 |
if msgid != self._lastseen: |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
163 |
print "%s:%d:" % (fname, lineno) |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
164 |
print " > %s" % line |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
165 |
self._lastseen = msgid |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
166 |
print " " + msg |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
167 |
|
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
168 |
_defaultlogger = norepeatlogger() |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
169 |
|
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
170 |
def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False): |
10719
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
171 |
"""checks style and portability of a given file |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
172 |
|
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
173 |
:f: filepath |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
174 |
:logfunc: function used to report error |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
175 |
logfunc(filename, linenumber, linecontent, errormessage) |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
176 |
:maxerr: number of error to display before arborting. |
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
177 |
Set to None (default) to report all errors |
10720
fbcccf9ec58f
check-code: add a return value to checkfile function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10719
diff
changeset
|
178 |
|
fbcccf9ec58f
check-code: add a return value to checkfile function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10719
diff
changeset
|
179 |
return True if no error is found, False otherwise. |
10719
3be9ae49b628
code-code: Add a logfunc argument to checkfile
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10718
diff
changeset
|
180 |
""" |
10720
fbcccf9ec58f
check-code: add a return value to checkfile function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10719
diff
changeset
|
181 |
result = True |
10281 | 182 |
for name, match, filters, pats in checks: |
183 |
fc = 0 |
|
184 |
if not re.match(match, f): |
|
185 |
continue |
|
186 |
pre = post = open(f).read() |
|
10287
5da892be3497
check-code: add some ignore hints
Matt Mackall <mpm@selenic.com>
parents:
10286
diff
changeset
|
187 |
if "no-" + "check-code" in pre: |
5da892be3497
check-code: add some ignore hints
Matt Mackall <mpm@selenic.com>
parents:
10286
diff
changeset
|
188 |
break |
10281 | 189 |
for p, r in filters: |
190 |
post = re.sub(p, r, post) |
|
191 |
# print post # uncomment to show filtered version |
|
192 |
z = enumerate(zip(pre.splitlines(), post.splitlines(True))) |
|
193 |
for n, l in z: |
|
10287
5da892be3497
check-code: add some ignore hints
Matt Mackall <mpm@selenic.com>
parents:
10286
diff
changeset
|
194 |
if "check-code" + "-ignore" in l[0]: |
5da892be3497
check-code: add some ignore hints
Matt Mackall <mpm@selenic.com>
parents:
10286
diff
changeset
|
195 |
continue |
10281 | 196 |
for p, msg in pats: |
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
197 |
if not warnings and msg.startswith("warning"): |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
198 |
continue |
10281 | 199 |
if re.search(p, l[1]): |
10723
8ea152e94484
check-code: fix check-code complaint
Matt Mackall <mpm@selenic.com>
parents:
10722
diff
changeset
|
200 |
logfunc(f, n + 1, l[0], msg) |
10281 | 201 |
fc += 1 |
10720
fbcccf9ec58f
check-code: add a return value to checkfile function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10719
diff
changeset
|
202 |
result = False |
10718
f18c37fd624f
check-code: Add a ``maxerr`` argument to the ``checkfile`` function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10717
diff
changeset
|
203 |
if maxerr is not None and fc >= maxerr: |
10281 | 204 |
print " (too many errors, giving up)" |
205 |
break |
|
206 |
break |
|
10720
fbcccf9ec58f
check-code: add a return value to checkfile function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10719
diff
changeset
|
207 |
return result |
10717
b1f4fcef99b3
check-code: Add a ``checkfile`` function
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10716
diff
changeset
|
208 |
|
10281 | 209 |
|
10716
5f92bde72eef
check-code: Only call check-code if __name__ = "__main__".
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10707
diff
changeset
|
210 |
if __name__ == "__main__": |
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
211 |
parser = optparse.OptionParser("%prog [options] [files]") |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
212 |
parser.add_option("-w", "--warnings", action="store_true", |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
213 |
help="include warning-level checks") |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
214 |
parser.add_option("-p", "--per-file", type="int", |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
215 |
help="max warnings per file") |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
216 |
|
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
217 |
parser.set_defaults(per_file=15, warnings=False) |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
218 |
(options, args) = parser.parse_args() |
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
219 |
|
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
220 |
if len(args) == 0: |
10716
5f92bde72eef
check-code: Only call check-code if __name__ = "__main__".
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10707
diff
changeset
|
221 |
check = glob.glob("*") |
5f92bde72eef
check-code: Only call check-code if __name__ = "__main__".
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10707
diff
changeset
|
222 |
else: |
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
223 |
check = args |
10281 | 224 |
|
10716
5f92bde72eef
check-code: Only call check-code if __name__ = "__main__".
Pierre-Yves David <pierre-yves.david@logilab.fr>
parents:
10707
diff
changeset
|
225 |
for f in check: |
10895
217557b26bc7
check-code: add a warnings level
Matt Mackall <mpm@selenic.com>
parents:
10814
diff
changeset
|
226 |
checkfile(f, maxerr=options.per_file, warnings=options.warnings) |