Mercurial > hg
annotate tests/hypothesishelpers.py @ 37048:fc5e261915b9
wireproto: require POST for all HTTPv2 requests
Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.
In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).
There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.
In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility
requirements.
This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.
There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.
Differential Revision: https://phab.mercurial-scm.org/D2837
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 13 Mar 2018 11:57:43 -0700 |
parents | 8699c89f3ae9 |
children | 2372284d9457 |
rev | line source |
---|---|
26842
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
1 # Helper module to use the Hypothesis tool in tests |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
2 # |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
3 # Copyright 2015 David R. MacIver |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
4 # |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
5 # For details see http://hypothesis.readthedocs.org |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
6 |
28728
8699c89f3ae9
py3: use print_function in hypothesishelpers.py
Robert Stanca <robert.stanca7@gmail.com>
parents:
28727
diff
changeset
|
7 from __future__ import absolute_import, print_function |
26842
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
8 import os |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
9 import sys |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
10 import traceback |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
11 |
27998
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
12 try: |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
13 # hypothesis 2.x |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
14 from hypothesis.configuration import set_hypothesis_home_dir |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
15 from hypothesis import settings |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
16 except ImportError: |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
17 # hypothesis 1.x |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
18 from hypothesis.settings import set_hypothesis_home_dir |
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
19 from hypothesis import Settings as settings |
26842
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
20 import hypothesis.strategies as st |
27998
84513a4fcc3a
tests: adjust for code move in Hypothesis 2.0.0
Yuya Nishihara <yuya@tcha.org>
parents:
26842
diff
changeset
|
21 from hypothesis import given |
26842
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
22 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
23 # hypothesis store data regarding generate example and code |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
24 set_hypothesis_home_dir(os.path.join( |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
25 os.getenv('TESTTMP'), ".hypothesis" |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
26 )) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
27 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
28 def check(*args, **kwargs): |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
29 """decorator to make a function a hypothesis test |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
30 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
31 Decorated function are run immediately (to be used doctest style)""" |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
32 def accept(f): |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
33 # Workaround for https://github.com/DRMacIver/hypothesis/issues/206 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
34 # Fixed in version 1.13 (released 2015 october 29th) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
35 f.__module__ = '__anon__' |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
36 try: |
27999
b30b40804a3f
tests: pass settings of hypothesis by with statement
Yuya Nishihara <yuya@tcha.org>
parents:
27998
diff
changeset
|
37 with settings(max_examples=2000): |
b30b40804a3f
tests: pass settings of hypothesis by with statement
Yuya Nishihara <yuya@tcha.org>
parents:
27998
diff
changeset
|
38 given(*args, **kwargs)(f)() |
26842
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
39 except Exception: |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
40 traceback.print_exc(file=sys.stdout) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
41 sys.exit(1) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
42 return accept |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
43 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
44 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
45 def roundtrips(data, decode, encode): |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
46 """helper to tests function that must do proper encode/decode roundtripping |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
47 """ |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
48 @given(data) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
49 def testroundtrips(value): |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
50 encoded = encode(value) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
51 decoded = decode(encoded) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
52 if decoded != value: |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
53 raise ValueError( |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
54 "Round trip failed: %s(%r) -> %s(%r) -> %r" % ( |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
55 encode.__name__, value, decode.__name__, encoded, |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
56 decoded |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
57 )) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
58 try: |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
59 testroundtrips() |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
60 except Exception: |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
61 # heredoc swallow traceback, we work around it |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
62 traceback.print_exc(file=sys.stdout) |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
63 raise |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
64 print("Round trip OK") |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
65 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
66 |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
67 # strategy for generating bytestring that might be an issue for Mercurial |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
68 bytestrings = ( |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
69 st.builds(lambda s, e: s.encode(e), st.text(), st.sampled_from([ |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
70 'utf-8', 'utf-16', |
0f76c64f5cc3
testing: add hypothesis fuzz testing
David R. MacIver <david@drmaciver.com>
parents:
diff
changeset
|
71 ]))) | st.binary() |