Mercurial > hg
annotate tests/test-check-pyflakes.t @ 37048:fc5e261915b9
wireproto: require POST for all HTTPv2 requests
Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.
In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).
There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.
In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility
requirements.
This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.
There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.
Differential Revision: https://phab.mercurial-scm.org/D2837
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 13 Mar 2018 11:57:43 -0700 |
parents | 1f3b54f392b0 |
children | 0e06d8086295 |
rev | line source |
---|---|
29138
a29f071751df
tests: mark test-check-pyflakes.t as requiring hg1.0+
timeless <timeless@mozdev.org>
parents:
27285
diff
changeset
|
1 #require test-repo pyflakes hg10 |
21208
0e1cbd3d52f7
tests: add repository check for pyflakes test
Matt Mackall <mpm@selenic.com>
parents:
20644
diff
changeset
|
2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
29138
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
19377
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
4 |
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
5 run pyflakes on all tracked files ending in .py or without a file ending |
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
6 (skipping binary file random-seed) |
21208
0e1cbd3d52f7
tests: add repository check for pyflakes test
Matt Mackall <mpm@selenic.com>
parents:
20644
diff
changeset
|
7 |
33367
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
8 $ cat > test.py <<EOF |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
9 > print(undefinedname) |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
10 > EOF |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
11 $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
12 test.py:1: undefined name 'undefinedname' |
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
13 |
33418
1f3b54f392b0
test-check-pyflakes: do not leave test.py in the repo
Jun Wu <quark@fb.com>
parents:
33367
diff
changeset
|
14 $ cd "`dirname "$TESTDIR"`" |
33367
6029939f7e98
filterpyflakes: move self-test into test file
Augie Fackler <raf@durin42.com>
parents:
33204
diff
changeset
|
15 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
16 $ testrepohg locate 'set:**.py or grep("^#!.*python")' \ |
33116
6c113a7dec52
tests: use the system hg for examining the local repository
Adam Simpkins <simpkins@fb.com>
parents:
32510
diff
changeset
|
17 > -X hgext/fsmonitor/pywatchman \ |
30894
5b60464efbde
tests: exclude python-zstandard from pyflakes analysis
Augie Fackler <augie@google.com>
parents:
30655
diff
changeset
|
18 > -X mercurial/pycompat.py -X contrib/python-zstandard \ |
29584
06587edd1233
pycompat: make pycompat demandimport friendly
Pulkit Goyal <7895pulkit@gmail.com>
parents:
29232
diff
changeset
|
19 > 2>/dev/null \ |
19377
0cb996ee8c6d
tests: run pyflakes on files from manifest which could be python files
Simon Heimberg <simohe@besonet.ch>
parents:
16350
diff
changeset
|
20 > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" |
22053
4354b1e35f53
tests: fix pyflakes test whitespace breakage
Matt Mackall <mpm@selenic.com>
parents:
22047
diff
changeset
|
21 |