Mercurial > hg
annotate tests/test-debian-packages.t @ 37048:fc5e261915b9
wireproto: require POST for all HTTPv2 requests
Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.
In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).
There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.
In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility
requirements.
This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.
There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.
Differential Revision: https://phab.mercurial-scm.org/D2837
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 13 Mar 2018 11:57:43 -0700 |
parents | 0133ca39c688 |
children | 7574ccd87200 |
rev | line source |
---|---|
34401
13d3f8aaed87
tests: add "have" check for dpkg builddeps
Kyle Lippincott <spectral@google.com>
parents:
34400
diff
changeset
|
1 #require test-repo slow debhelper debdeps |
26148
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
26148
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
4 $ testrepohgenv |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
26148
diff
changeset
|
5 |
26148
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
6 Ensure debuild doesn't run the testsuite, as that could get silly. |
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
7 $ DEB_BUILD_OPTIONS=nocheck |
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
8 $ export DEB_BUILD_OPTIONS |
26147
a02c22e48142
test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
9 $ OUTPUTDIR=`pwd` |
a02c22e48142
test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
10 $ export OUTPUTDIR |
a02c22e48142
test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
11 |
a02c22e48142
test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
12 $ cd "$TESTDIR"/.. |
a02c22e48142
test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
13 $ make deb > $OUTPUTDIR/build.log 2>&1 |
a02c22e48142
test-debian-packages: new test for testing construction of debian packages
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
14 $ cd $OUTPUTDIR |
34400
3d936da4f97b
tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)
Kyle Lippincott <spectral@google.com>
parents:
33204
diff
changeset
|
15 $ ls *.deb | grep -v 'dbg' |
26148
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
16 mercurial-common_*.deb (glob) |
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
17 mercurial_*.deb (glob) |
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
18 main deb should have .so but no .py |
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
19 $ dpkg --contents mercurial_*.deb | egrep '(localrepo|parsers)' |
34400
3d936da4f97b
tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)
Kyle Lippincott <spectral@google.com>
parents:
33204
diff
changeset
|
20 * ./usr/lib/python2.7/dist-packages/mercurial/cext/parsers*.so (glob) |
26148
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
21 mercurial-common should have py but no .so or pyc |
34400
3d936da4f97b
tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)
Kyle Lippincott <spectral@google.com>
parents:
33204
diff
changeset
|
22 $ dpkg --contents mercurial-common_*.deb | egrep '(localrepo|parsers.*so)' |
26148
7f49efcaa9b4
debian: switch to using debhelper and dh_python2 to build debs
Augie Fackler <augie@google.com>
parents:
26147
diff
changeset
|
23 * ./usr/lib/python2.7/dist-packages/mercurial/localrepo.py (glob) |
34405
9ecc622ca23f
deb: install zsh completions to /usr/share/zsh/vendor-completions
Kyle Lippincott <spectral@google.com>
parents:
34401
diff
changeset
|
24 zsh completions should be in the common package |
9ecc622ca23f
deb: install zsh completions to /usr/share/zsh/vendor-completions
Kyle Lippincott <spectral@google.com>
parents:
34401
diff
changeset
|
25 $ dpkg --contents mercurial-common_*.deb | egrep 'zsh.*[^/]$' |
9ecc622ca23f
deb: install zsh completions to /usr/share/zsh/vendor-completions
Kyle Lippincott <spectral@google.com>
parents:
34401
diff
changeset
|
26 * ./usr/share/zsh/vendor-completions/_hg (glob) |
34406
0133ca39c688
deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents:
34405
diff
changeset
|
27 chg should be installed alongside hg, in the 'mercurial' package |
0133ca39c688
deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents:
34405
diff
changeset
|
28 $ dpkg --contents mercurial_*.deb | egrep 'chg$' |
0133ca39c688
deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents:
34405
diff
changeset
|
29 * ./usr/bin/chg (glob) |
0133ca39c688
deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents:
34405
diff
changeset
|
30 chg should come with a man page |
0133ca39c688
deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents:
34405
diff
changeset
|
31 $ dpkg --contents mercurial_*.deb | egrep 'man.*chg' |
0133ca39c688
deb: build and install chg
Kyle Lippincott <spectral@google.com>
parents:
34405
diff
changeset
|
32 * ./usr/share/man/man1/chg.1.gz (glob) |