Mercurial > hg
annotate tests/test-diff-hashes.t @ 37048:fc5e261915b9
wireproto: require POST for all HTTPv2 requests
Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.
In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).
There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.
In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility
requirements.
This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.
There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.
Differential Revision: https://phab.mercurial-scm.org/D2837
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 13 Mar 2018 11:57:43 -0700 |
parents | f2719b387380 |
children | 251332dbf33d |
rev | line source |
---|---|
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
1 $ hg init a |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
2 $ cd a |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
3 |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
4 $ hg diff inexistent1 inexistent2 |
15521
117f9190c1ba
tests: hide 'No such file or directory' messages
Mads Kiilerich <mads@kiilerich.com>
parents:
12156
diff
changeset
|
5 inexistent1: * (glob) |
117f9190c1ba
tests: hide 'No such file or directory' messages
Mads Kiilerich <mads@kiilerich.com>
parents:
12156
diff
changeset
|
6 inexistent2: * (glob) |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
7 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
8 $ echo bar > foo |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
9 $ hg add foo |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
10 $ hg ci -m 'add foo' |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
11 |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
12 $ echo foobar > foo |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
13 $ hg ci -m 'change foo' |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
14 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
15 $ hg --quiet diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
16 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
17 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
18 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
19 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
20 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
21 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
22 $ hg diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
23 diff -r a99fb63adac3 -r 9b8568d3af2f foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
24 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
25 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
26 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
27 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
28 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
29 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
30 $ hg --verbose diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
31 diff -r a99fb63adac3 -r 9b8568d3af2f foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
32 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
33 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
34 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
35 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
36 +foobar |
3387
2065789f6a3e
use short hashes with diff -v
Alexis S. L. Carvalho <alexis@cecm.usp.br>
parents:
diff
changeset
|
37 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
38 $ hg --debug diff -r 0 -r 1 |
12156
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
39 diff -r a99fb63adac3f31816a22f665bc3b7a7655b30f4 -r 9b8568d3af2f1749445eef03aede868a6f39f210 foo |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
40 --- a/foo Thu Jan 01 00:00:00 1970 +0000 |
4c94b6d0fb1c
tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents:
12137
diff
changeset
|
41 +++ b/foo Thu Jan 01 00:00:00 1970 +0000 |
12137
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
42 @@ -1,1 +1,1 @@ |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
43 -bar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
44 +foobar |
e1814ff260c2
tests: unify test-diff-hashes
Adrian Buehlmann <adrian@cadifra.com>
parents:
5689
diff
changeset
|
45 |
16913
f2719b387380
tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents:
15521
diff
changeset
|
46 $ cd .. |