Mercurial > hg
annotate tests/test-http-branchmap.t @ 37048:fc5e261915b9
wireproto: require POST for all HTTPv2 requests
Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.
In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).
There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.
In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility
requirements.
This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.
There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.
Differential Revision: https://phab.mercurial-scm.org/D2837
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 13 Mar 2018 11:57:43 -0700 |
parents | 1e0c9f9f6f36 |
children | b4b7427b5786 |
rev | line source |
---|---|
22046
7a9cbb315d84
tests: replace exit 80 with #require
Matt Mackall <mpm@selenic.com>
parents:
17467
diff
changeset
|
1 #require killdaemons |
9879
7bb004fc14ec
Extend test-branchmap to test c51494c53841
Thomas Arendsen Hein <thomas@intevation.de>
parents:
9789
diff
changeset
|
2 |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
3 $ hgserve() { |
17467
448d0c452140
test-http-branchmap: enable on Windows
Patrick Mezard <patrick@mezard.eu>
parents:
15623
diff
changeset
|
4 > hg serve -a localhost -p $HGPORT1 -d --pid-file=hg.pid \ |
448d0c452140
test-http-branchmap: enable on Windows
Patrick Mezard <patrick@mezard.eu>
parents:
15623
diff
changeset
|
5 > -E errors.log -v $@ > startup.log |
448d0c452140
test-http-branchmap: enable on Windows
Patrick Mezard <patrick@mezard.eu>
parents:
15623
diff
changeset
|
6 > # Grepping hg serve stdout would hang on Windows |
448d0c452140
test-http-branchmap: enable on Windows
Patrick Mezard <patrick@mezard.eu>
parents:
15623
diff
changeset
|
7 > grep -v 'listening at' startup.log |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
8 > cat hg.pid >> "$DAEMON_PIDS" |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
9 > } |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
10 $ hg init a |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
11 $ hg --encoding utf-8 -R a branch æ |
12942
05fffd665170
tests: use (esc) for all non-ASCII test output
Mads Kiilerich <mads@kiilerich.com>
parents:
12700
diff
changeset
|
12 marked working directory as branch \xc3\xa6 (esc) |
15615 | 13 (branches are permanent and global, did you want a bookmark?) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
14 $ echo foo > a/foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
15 $ hg -R a ci -Am foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
16 adding foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
17 $ hgserve -R a --config web.push_ssl=False --config web.allow_push=* --encoding latin1 |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
18 $ hg --encoding utf-8 clone http://localhost:$HGPORT1 b |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
19 requesting all changes |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
20 adding changesets |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
21 adding manifests |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
22 adding file changes |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
23 added 1 changesets with 1 changes to 1 files |
34661
eb586ed5d8ce
transaction-summary: show the range of new revisions upon pull/unbundle (BC)
Denis Laxalde <denis.laxalde@logilab.fr>
parents:
33335
diff
changeset
|
24 new changesets 867c11ce77b8 |
12942
05fffd665170
tests: use (esc) for all non-ASCII test output
Mads Kiilerich <mads@kiilerich.com>
parents:
12700
diff
changeset
|
25 updating to branch \xc3\xa6 (esc) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
26 1 files updated, 0 files merged, 0 files removed, 0 files unresolved |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
27 $ hg --encoding utf-8 -R b log |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
28 changeset: 0:867c11ce77b8 |
12942
05fffd665170
tests: use (esc) for all non-ASCII test output
Mads Kiilerich <mads@kiilerich.com>
parents:
12700
diff
changeset
|
29 branch: \xc3\xa6 (esc) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
30 tag: tip |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
31 user: test |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
32 date: Thu Jan 01 00:00:00 1970 +0000 |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
33 summary: foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
34 |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
35 $ echo bar >> b/foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
36 $ hg -R b ci -m bar |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
37 $ hg --encoding utf-8 -R b push |
13815
d066d8d652c8
url: add trailing slashes to URLs with hostnames that don't have one
Brodie Rao <brodie@bitheap.org>
parents:
12942
diff
changeset
|
38 pushing to http://localhost:$HGPORT1/ |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
39 searching for changes |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
40 remote: adding changesets |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
41 remote: adding manifests |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
42 remote: adding file changes |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
43 remote: added 1 changesets with 1 changes to 1 files |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
44 $ hg -R a --encoding utf-8 log |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
45 changeset: 1:58e7c90d67cb |
12942
05fffd665170
tests: use (esc) for all non-ASCII test output
Mads Kiilerich <mads@kiilerich.com>
parents:
12700
diff
changeset
|
46 branch: \xc3\xa6 (esc) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
47 tag: tip |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
48 user: test |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
49 date: Thu Jan 01 00:00:00 1970 +0000 |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
50 summary: bar |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
51 |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
52 changeset: 0:867c11ce77b8 |
12942
05fffd665170
tests: use (esc) for all non-ASCII test output
Mads Kiilerich <mads@kiilerich.com>
parents:
12700
diff
changeset
|
53 branch: \xc3\xa6 (esc) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
54 user: test |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
55 date: Thu Jan 01 00:00:00 1970 +0000 |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
56 summary: foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
57 |
25472
4d2b9b304ad0
tests: drop explicit $TESTDIR from executables
Matt Mackall <mpm@selenic.com>
parents:
22046
diff
changeset
|
58 $ killdaemons.py hg.pid |
9879
7bb004fc14ec
Extend test-branchmap to test c51494c53841
Thomas Arendsen Hein <thomas@intevation.de>
parents:
9789
diff
changeset
|
59 |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
60 verify 7e7d56fe4833 (encoding fallback in branchmap to maintain compatibility with 1.3.x) |
9879
7bb004fc14ec
Extend test-branchmap to test c51494c53841
Thomas Arendsen Hein <thomas@intevation.de>
parents:
9789
diff
changeset
|
61 |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
62 $ cat <<EOF > oldhg |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
63 > import sys |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
64 > from mercurial import ui, hg, commands |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
65 > |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
66 > class StdoutWrapper(object): |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
67 > def __init__(self, stdout): |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
68 > self._file = stdout |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
69 > |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
70 > def write(self, data): |
36279
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
71 > if data == b'47\n': |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
72 > # latin1 encoding is one %xx (3 bytes) shorter |
36279
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
73 > data = b'44\n' |
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
74 > elif data.startswith(b'%C3%A6 '): |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
75 > # translate to latin1 encoding |
36279
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
76 > data = b'%%E6 %s' % data[7:] |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
77 > self._file.write(data) |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
78 > |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
79 > def __getattr__(self, name): |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
80 > return getattr(self._file, name) |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
81 > |
36279
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
82 > sys.stdout = StdoutWrapper(getattr(sys.stdout, 'buffer', sys.stdout)) |
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
83 > sys.stderr = StdoutWrapper(getattr(sys.stderr, 'buffer', sys.stderr)) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
84 > |
30559
d83ca854fa21
ui: factor out ui.load() to create a ui without loading configs (API)
Yuya Nishihara <yuya@tcha.org>
parents:
25472
diff
changeset
|
85 > myui = ui.ui.load() |
36279
1e0c9f9f6f36
tests: port inline Python in test-http-branchmap.t to Python 3
Augie Fackler <augie@google.com>
parents:
34661
diff
changeset
|
86 > repo = hg.repository(myui, b'a') |
14647
2e9f379de0ac
serve: add --cmdserver option to communicate with hg over a pipe
Idan Kamara <idankk86@gmail.com>
parents:
13815
diff
changeset
|
87 > commands.serve(myui, repo, stdio=True, cmdserver=False) |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
88 > EOF |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
89 $ echo baz >> b/foo |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
90 $ hg -R b ci -m baz |
33335
72f051f9a7d8
tests: quote $PYTHON for Windows
Matt Harbison <matt_harbison@yahoo.com>
parents:
33286
diff
changeset
|
91 $ hg push -R b -e "\"$PYTHON\" oldhg" ssh://dummy/ --encoding latin1 |
12447
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
92 pushing to ssh://dummy/ |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
93 searching for changes |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
94 remote: adding changesets |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
95 remote: adding manifests |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
96 remote: adding file changes |
f5f90d3808e2
tests: unify test-http-branchmap
Matt Mackall <mpm@selenic.com>
parents:
11617
diff
changeset
|
97 remote: added 1 changesets with 1 changes to 1 files |