annotate tests/test-merge2.t @ 37048:fc5e261915b9

wireproto: require POST for all HTTPv2 requests Wire protocol version 1 transfers argument data via request headers by default. This has historically caused problems because servers institute limits on the length of individual HTTP headers as well as the total size of all request headers. Mercurial servers can advertise the maximum length of an individual header. But there's no guarantee any intermediate HTTP agents will accept headers up to that length. In the existing wire protocol, server operators typically also key off the HTTP request method to implement authentication. For example, GET requests translate to read-only requests and can be allowed. But read-write commands must use POST and require authentication. This has typically worked because the only wire protocol commands that use POST modify the repo (e.g. the "unbundle" command). There is an experimental feature to enable clients to transmit argument data via POST request bodies. This is technically a better and more robust solution. But we can't enable it by default because of servers assuming POST means write access. In version 2 of the wire protocol, the permissions of a request are encoded in the URL. And with it being a new protocol in a new URL space, we're not constrained by backwards compatibility requirements. This commit adopts the technically superior mechanism of using HTTP request bodies to send argument data by requiring POST for all commands. Strictly speaking, it may be possible to send request bodies on GET requests. But my experience is that not all HTTP stacks support this. POST pretty much always works. Using POST for read-only operations does sacrifice some RESTful design purity. But this API cares about practicality, not about being in Roy T. Fielding's REST ivory tower. There's a chance we may relax this restriction in the future. But for now, I want to see how far we can get with a POST only API. Differential Revision: https://phab.mercurial-scm.org/D2837
author Gregory Szorc <gregory.szorc@gmail.com>
date Tue, 13 Mar 2018 11:57:43 -0700
parents f2719b387380
children 1850066f9e36
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13956
ffb5c09ba822 tests: remove redundant mkdir
Martin Geisler <mg@lazybytes.net>
parents: 12156
diff changeset
1 $ hg init t
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
2 $ cd t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
3 $ echo This is file a1 > a
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
4 $ hg add a
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
5 $ hg commit -m "commit #0"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
6 $ echo This is file b1 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
7 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
8 $ hg commit -m "commit #1"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
9 $ rm b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
10 $ hg update 0
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
11 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
12 $ echo This is file b2 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
13 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
14 $ hg commit -m "commit #2"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
15 created new head
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
16 $ cd ..; rm -r t
409
feadc9697b43 Pick up tests from previous patch
mpm@selenic.com
parents:
diff changeset
17
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
18 $ mkdir t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
19 $ cd t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
20 $ hg init
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
21 $ echo This is file a1 > a
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
22 $ hg add a
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
23 $ hg commit -m "commit #0"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
24 $ echo This is file b1 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
25 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
26 $ hg commit -m "commit #1"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
27 $ rm b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
28 $ hg update 0
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
29 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
30 $ echo This is file b2 > b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
31 $ hg commit -A -m "commit #2"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
32 adding b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
33 created new head
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
34 $ cd ..; rm -r t
409
feadc9697b43 Pick up tests from previous patch
mpm@selenic.com
parents:
diff changeset
35
13956
ffb5c09ba822 tests: remove redundant mkdir
Martin Geisler <mg@lazybytes.net>
parents: 12156
diff changeset
36 $ hg init t
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
37 $ cd t
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
38 $ echo This is file a1 > a
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
39 $ hg add a
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
40 $ hg commit -m "commit #0"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
41 $ echo This is file b1 > b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
42 $ hg add b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
43 $ hg commit -m "commit #1"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
44 $ rm b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
45 $ hg remove b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
46 $ hg update 0
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
47 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
48 $ echo This is file b2 > b
12156
4c94b6d0fb1c tests: remove unneeded -d flags
Martin Geisler <mg@lazybytes.net>
parents: 11976
diff changeset
49 $ hg commit -A -m "commit #2"
11976
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
50 adding b
b28fc3b3efd6 tests: unify test-merge2
Pradeepkumar Gayam <in3xes@gmail.com>
parents: 3988
diff changeset
51 created new head
16913
f2719b387380 tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents: 13956
diff changeset
52
f2719b387380 tests: add missing trailing 'cd ..'
Mads Kiilerich <mads@kiilerich.com>
parents: 13956
diff changeset
53 $ cd ..