Mercurial > hg
annotate tests/test-ui-color.py @ 37048:fc5e261915b9
wireproto: require POST for all HTTPv2 requests
Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.
In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).
There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.
In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility
requirements.
This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.
There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.
Differential Revision: https://phab.mercurial-scm.org/D2837
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 13 Mar 2018 11:57:43 -0700 |
parents | 0f36926b2651 |
children | b8c2004a8d2b |
rev | line source |
---|---|
28915
40afa22bee9b
tests: make test-ui-color use absolute_import
Pulkit Goyal <7895pulkit@gmail.com>
parents:
28682
diff
changeset
|
1 from __future__ import absolute_import, print_function |
40afa22bee9b
tests: make test-ui-color use absolute_import
Pulkit Goyal <7895pulkit@gmail.com>
parents:
28682
diff
changeset
|
2 |
19322
ff1586a3adc5
cleanup: remove unused imports
Simon Heimberg <simohe@besonet.ch>
parents:
17956
diff
changeset
|
3 import os |
28915
40afa22bee9b
tests: make test-ui-color use absolute_import
Pulkit Goyal <7895pulkit@gmail.com>
parents:
28682
diff
changeset
|
4 from mercurial import ( |
40afa22bee9b
tests: make test-ui-color use absolute_import
Pulkit Goyal <7895pulkit@gmail.com>
parents:
28682
diff
changeset
|
5 dispatch, |
40afa22bee9b
tests: make test-ui-color use absolute_import
Pulkit Goyal <7895pulkit@gmail.com>
parents:
28682
diff
changeset
|
6 ui as uimod, |
40afa22bee9b
tests: make test-ui-color use absolute_import
Pulkit Goyal <7895pulkit@gmail.com>
parents:
28682
diff
changeset
|
7 ) |
11732
386e56ecfb78
color: call correct superclass method in write_err
Brodie Rao <brodie@bitheap.org>
parents:
diff
changeset
|
8 |
386e56ecfb78
color: call correct superclass method in write_err
Brodie Rao <brodie@bitheap.org>
parents:
diff
changeset
|
9 # ensure errors aren't buffered |
31095
b4cb86ab4c71
color: drop the 'colorui' class
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
30559
diff
changeset
|
10 testui = uimod.ui() |
11732
386e56ecfb78
color: call correct superclass method in write_err
Brodie Rao <brodie@bitheap.org>
parents:
diff
changeset
|
11 testui.pushbuffer() |
36336
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
12 testui.write((b'buffered\n')) |
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
13 testui.warn((b'warning\n')) |
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
14 testui.write_err(b'error\n') |
28682
2e5be704bc96
py3: make test-ui-color use print_function
Pulkit Goyal <7895pulkit@gmail.com>
parents:
19322
diff
changeset
|
15 print(repr(testui.popbuffer())) |
14516
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
16 |
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
17 # test dispatch.dispatch with the same ui object |
36337
0f36926b2651
py3: make sure we open file in bytes mode
Pulkit Goyal <7895pulkit@gmail.com>
parents:
36336
diff
changeset
|
18 hgrc = open(os.environ["HGRCPATH"], 'wb') |
36336
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
19 hgrc.write(b'[extensions]\n') |
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
20 hgrc.write(b'color=\n') |
14516
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
21 hgrc.close() |
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
22 |
30559
d83ca854fa21
ui: factor out ui.load() to create a ui without loading configs (API)
Yuya Nishihara <yuya@tcha.org>
parents:
28915
diff
changeset
|
23 ui_ = uimod.ui.load() |
36336
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
24 ui_.setconfig(b'ui', b'formatted', b'True') |
14516
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
25 |
14614
afccc64eea73
ui: use I/O descriptors internally
Idan Kamara <idankk86@gmail.com>
parents:
14516
diff
changeset
|
26 # we're not interested in the output, so write that to devnull |
36337
0f36926b2651
py3: make sure we open file in bytes mode
Pulkit Goyal <7895pulkit@gmail.com>
parents:
36336
diff
changeset
|
27 ui_.fout = open(os.devnull, 'wb') |
14614
afccc64eea73
ui: use I/O descriptors internally
Idan Kamara <idankk86@gmail.com>
parents:
14516
diff
changeset
|
28 |
14516
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
29 # call some arbitrary command just so we go through |
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
30 # color's wrapped _runcommand twice. |
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
31 def runcmd(): |
36336
236596a67a54
py3: add b'' to test-ui-color.py
Pulkit Goyal <7895pulkit@gmail.com>
parents:
31095
diff
changeset
|
32 dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_)) |
14516
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
33 |
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
34 runcmd() |
31095
b4cb86ab4c71
color: drop the 'colorui' class
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
30559
diff
changeset
|
35 print("colored? %s" % (ui_._colormode is not None)) |
14516
842a9179132c
color: check if ui is already a subclass of colorui before wrapping it
Idan Kamara <idankk86@gmail.com>
parents:
12865
diff
changeset
|
36 runcmd() |
31095
b4cb86ab4c71
color: drop the 'colorui' class
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
30559
diff
changeset
|
37 print("colored? %s" % (ui_._colormode is not None)) |
b4cb86ab4c71
color: drop the 'colorui' class
Pierre-Yves David <pierre-yves.david@ens-lyon.org>
parents:
30559
diff
changeset
|
38 |