comparison mercurial/revlog.py @ 41286:00b314c42094

revlog: document that mmap resources are released implicitly by GC

It's okay-ish, but currently the open fd and the mapping itself are leaked
until the indexdata is deallocated. If revlog had close(), the underlying
resources should be closed there as well, but AFAIK there's no such hook
point.

41285:cf8677cd7286

        self._initempty = True
        try:
            with self._indexfp() as f:
                if (mmapindexthreshold is not None and
                    self.opener.fstat(f).st_size >= mmapindexthreshold):
                    indexdata = util.buffer(util.mmapread(f))
                else:
                    indexdata = f.read()
            if len(indexdata) > 0:
                versionflags = versionformat_unpack(indexdata[:4])[0]

41286:00b314c42094

        self._initempty = True
        try:
            with self._indexfp() as f:
                if (mmapindexthreshold is not None and
                    self.opener.fstat(f).st_size >= mmapindexthreshold):
                    # TODO: should .close() to release resources without
                    # relying on Python GC
                    indexdata = util.buffer(util.mmapread(f))
                else:
                    indexdata = f.read()
            if len(indexdata) > 0:
                versionflags = versionformat_unpack(indexdata[:4])[0]