comparison rust/hg-core/src/dirstate_tree/on_disk.rs @ 47331:0252600fd1cf

dirstate-tree: Downgrade `&mut Node` to `&Node` in status and serialization

Mutable access is not used, and upcoming changes will make it more costly
(with copy-on-write nodes that can be read from disk representation)

Differential Revision: https://phab.mercurial-scm.org/D10745

47330:73f23e7610f8

    out[..header_len].copy_from_slice(header.as_bytes());
    Ok(out)
}

fn write_nodes(
    nodes: &mut dirstate_map::ChildNodes,
    out: &mut Vec<u8>,
) -> Result<ChildNodes, DirstateError> {
    // `dirstate_map::ChildNodes` is a `HashMap` with undefined iteration
    // order. Sort to enable binary search in the written file.
    let nodes = dirstate_map::Node::sorted(nodes);

    // First accumulate serialized nodes in a `Vec`
    let mut on_disk_nodes = Vec::with_capacity(nodes.len());
    for (full_path, node) in nodes {
        on_disk_nodes.push(Node {
            children: write_nodes(&mut node.children, out)?,
            tracked_descendants_count: node.tracked_descendants_count.into(),
            full_path: write_slice::<u8>(
                full_path.full_path().as_bytes(),
                out,
            ),

                Slice {
                    start: 0.into(),
                    len: 0.into(),
                }
            },
            entry: if let Some(entry) = &mut node.entry {
                OptEntry {
                    state: entry.state.into(),
                    mode: entry.mode.into(),
                    mtime: entry.mtime.into(),
                    size: entry.size.into(),

47331:0252600fd1cf

    out[..header_len].copy_from_slice(header.as_bytes());
    Ok(out)
}

fn write_nodes(
    nodes: &dirstate_map::ChildNodes,
    out: &mut Vec<u8>,
) -> Result<ChildNodes, DirstateError> {
    // `dirstate_map::ChildNodes` is a `HashMap` with undefined iteration
    // order. Sort to enable binary search in the written file.
    let nodes = dirstate_map::Node::sorted(nodes);

    // First accumulate serialized nodes in a `Vec`
    let mut on_disk_nodes = Vec::with_capacity(nodes.len());
    for (full_path, node) in nodes {
        on_disk_nodes.push(Node {
            children: write_nodes(&node.children, out)?,
            tracked_descendants_count: node.tracked_descendants_count.into(),
            full_path: write_slice::<u8>(
                full_path.full_path().as_bytes(),
                out,
            ),

                Slice {
                    start: 0.into(),
                    len: 0.into(),
                }
            },
            entry: if let Some(entry) = &node.entry {
                OptEntry {
                    state: entry.state.into(),
                    mode: entry.mode.into(),
                    mtime: entry.mtime.into(),
                    size: entry.size.into(),