comparison mercurial/dirstate.py @ 50154:028fb89a0539

dirstate: enforce change context for hacky_extension_update_file

This was the last method not scoped yet

50153:98890baf324e

            p2_info=p2_info,
            possibly_dirty=possibly_dirty,
            parentfiledata=parentfiledata,
        )

    # XXX since this make the dirstate dirty, we should enforce that it is done
    # withing an appropriate change-context that scope the change and ensure it
    # eventually get written on disk (or rolled back)
    def hacky_extension_update_file(self, *args, **kwargs):
        """NEVER USE THIS, YOU DO NOT NEED IT

        This function is a variant of "update_file" to be called by a small set
        of extensions, it also adjust the internal state of file, but can be

        This function could probably be replaced by more semantic one (like
        "adjust expected size" or "always revalidate file content", etc)
        however at the time where this is writen, this is too much of a detour
        to be considered.
        """
        self._update_file(
            *args,
            **kwargs,
        )

50154:028fb89a0539

            p2_info=p2_info,
            possibly_dirty=possibly_dirty,
            parentfiledata=parentfiledata,
        )

    def hacky_extension_update_file(self, *args, **kwargs):
        """NEVER USE THIS, YOU DO NOT NEED IT

        This function is a variant of "update_file" to be called by a small set
        of extensions, it also adjust the internal state of file, but can be

        This function could probably be replaced by more semantic one (like
        "adjust expected size" or "always revalidate file content", etc)
        however at the time where this is writen, this is too much of a detour
        to be considered.
        """
        if not (self._changing_level > 0 or self._running_status > 0):
            msg = "requires a changes context"
            raise error.ProgrammingError(msg)
        self._update_file(
            *args,
            **kwargs,
        )