comparison tests/run-tests.py @ 35991:04304b779df1

tests: raise a better error when patterns are wrongly formatted

It is fairly easy to make mistakes when merging conflict in the pattern file.
A common mistake is to forget adding an extra trailing comma changing the
length of the tuple.

We now detect such error and raise a better error message that helps to find
it.

35990:eefb5d603482

            data = {}
            with open(replacementfile, mode='rb') as source:
                # the intermediate 'compile' step help with debugging
                code = compile(source.read(), replacementfile, 'exec')
                exec(code, data)
                r.extend(data.get('substitutions', ()))
        return r

    def _escapepath(self, p):
        if os.name == 'nt':
            return (

35991:04304b779df1

            data = {}
            with open(replacementfile, mode='rb') as source:
                # the intermediate 'compile' step help with debugging
                code = compile(source.read(), replacementfile, 'exec')
                exec(code, data)
                for value in data.get('substitutions', ()):
                    if len(value) != 2:
                        msg = 'malformatted substitution in %s: %r'
                        msg %= (replacementfile, value)
                        raise ValueError(msg)
                    r.append(value)
        return r

    def _escapepath(self, p):
        if os.name == 'nt':
            return (