Mercurial > hg
comparison tests/f @ 36948:0585337ea787
cleanup: fix some latent open(path).read() et al calls we previously missed
This pattern was banned by check-code way back in 1b4b82063ce2 (may of
2011), but due to a regular expression rewriting bug in check-code
these particular callsites were never detected. Python 3.7 caught the
bug, which then exposed these errors.
Differential Revision: https://phab.mercurial-scm.org/D2863
author | Augie Fackler <augie@google.com> |
---|---|
date | Wed, 14 Mar 2018 15:39:28 -0400 |
parents | c69e78ef2b54 |
children | 06c85cbd6824 |
comparison
equal
deleted
inserted
replaced
36947:3d0178bf1039 | 36948:0585337ea787 |
---|---|
59 facts = [] | 59 facts = [] |
60 if isfile: | 60 if isfile: |
61 if opts.type: | 61 if opts.type: |
62 facts.append(b'file') | 62 facts.append(b'file') |
63 if any((opts.hexdump, opts.dump, opts.md5, opts.sha1, opts.sha256)): | 63 if any((opts.hexdump, opts.dump, opts.md5, opts.sha1, opts.sha256)): |
64 content = open(f, 'rb').read() | 64 with open(f, 'rb') as fobj: |
65 content = fobj.read() | |
65 elif islink: | 66 elif islink: |
66 if opts.type: | 67 if opts.type: |
67 facts.append(b'link') | 68 facts.append(b'link') |
68 content = os.readlink(f) | 69 content = os.readlink(f) |
69 elif isstdin: | 70 elif isstdin: |