comparison tests/f @ 36948:0585337ea787

cleanup: fix some latent open(path).read() et al calls we previously missed

This pattern was banned by check-code way back in 1b4b82063ce2 (may of
2011), but due to a regular expression rewriting bug in check-code
these particular callsites were never detected. Python 3.7 caught the
bug, which then exposed these errors.

Differential Revision: https://phab.mercurial-scm.org/D2863

36947:3d0178bf1039

        facts = []
        if isfile:
            if opts.type:
                facts.append(b'file')
            if any((opts.hexdump, opts.dump, opts.md5, opts.sha1, opts.sha256)):
                content = open(f, 'rb').read()
        elif islink:
            if opts.type:
                facts.append(b'link')
            content = os.readlink(f)
        elif isstdin:

36948:0585337ea787

        facts = []
        if isfile:
            if opts.type:
                facts.append(b'file')
            if any((opts.hexdump, opts.dump, opts.md5, opts.sha1, opts.sha256)):
                with open(f, 'rb') as fobj:
                    content = fobj.read()
        elif islink:
            if opts.type:
                facts.append(b'link')
            content = os.readlink(f)
        elif isstdin: