Mercurial > hg
comparison contrib/check-code.py @ 32604:071423d0a584
check-code: suggest policy.importmod
This forbids patterns like `from mercurial.cext import parsers` which breaks
pure.
| author | Jun Wu <quark@fb.com> |
|---|---|
| date | Wed, 31 May 2017 11:41:54 -0700 |
| parents | 1651977596c0 |
| children | 0c09afdf5704 |
comparison
equal
deleted
inserted
replaced
| 32603:5d44d7d4076e | 32604:071423d0a584 |
|---|---|
| 338 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), | 338 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), |
| 339 (r'^import cPickle', "don't use cPickle, use util.pickle"), | 339 (r'^import cPickle', "don't use cPickle, use util.pickle"), |
| 340 (r'^import pickle', "don't use pickle, use util.pickle"), | 340 (r'^import pickle', "don't use pickle, use util.pickle"), |
| 341 (r'^import httplib', "don't use httplib, use util.httplib"), | 341 (r'^import httplib', "don't use httplib, use util.httplib"), |
| 342 (r'^import BaseHTTPServer', "use util.httpserver instead"), | 342 (r'^import BaseHTTPServer', "use util.httpserver instead"), |
| 343 (r'^(from|import) mercurial\.(cext|pure|cffi)', | |
| 344 "use mercurial.policy.importmod instead"), | |
| 343 (r'\.next\(\)', "don't use .next(), use next(...)"), | 345 (r'\.next\(\)', "don't use .next(), use next(...)"), |
| 344 (r'([a-z]*).revision\(\1\.node\(', | 346 (r'([a-z]*).revision\(\1\.node\(', |
| 345 "don't convert rev to node before passing to revision(nodeorrev)"), | 347 "don't convert rev to node before passing to revision(nodeorrev)"), |
| 346 | 348 |
| 347 # rules depending on implementation of repquote() | 349 # rules depending on implementation of repquote() |