comparison tests/run-tests.py @ 7813:076401cf2b63

run-tests.py: avoid using popen2.Popen4 - use subprocess instead

Use subprocess to emulate Popen4 if available - similar to how it is done in
util.py.

Using popen2 under python 2.6 gives
DeprecationWarning: The popen2 module is deprecated.  Use the subprocess module.

7812:18048153fd4e

import difflib
import errno
import optparse
import os
import popen2
import shutil
import signal
import sys
import tempfile
import time

        output = fromchild.read()
        ret = fromchild.close()
        if ret == None:
            ret = 0
    else:
        proc = popen2.Popen4(cmd)
        try:
            output = ''
            proc.tochild.close()
            output = proc.fromchild.read()
            ret = proc.wait()

7813:076401cf2b63

import difflib
import errno
import optparse
import os
try:
    import subprocess
    subprocess.Popen  # trigger ImportError early
    closefds = os.name == 'posix'
    def Popen4(cmd, bufsize=-1):
        p = subprocess.Popen(cmd, shell=True, bufsize=bufsize,
                             close_fds=closefds,
                             stdin=subprocess.PIPE, stdout=subprocess.PIPE,
                             stderr=subprocess.STDOUT)
        p.fromchild = p.stdout
        p.tochild = p.stdin
        p.childerr = p.stderr
        return p
except ImportError:
    subprocess = None
    from popen2 import Popen4
import shutil
import signal
import sys
import tempfile
import time

        output = fromchild.read()
        ret = fromchild.close()
        if ret == None:
            ret = 0
    else:
        proc = Popen4(cmd)
        try:
            output = ''
            proc.tochild.close()
            output = proc.fromchild.read()
            ret = proc.wait()