comparison mercurial/ui.py @ 46024:07b0a687c01a stable

ui: ensure `getpass()` returns bytes

Previously, this could return either bytes or str.  I'm not sure which direction
we should go in, but since the input is bytes, I guess bytes makes sense as
output.  `debuguigetpass` crashed because it assumed bytes would be returned,
`sslcontext.load_cert_chain()` is happy with bytes or str if the type info in
PyCharm is correct, and `smtplib.SMTP.login()` wants str.

I couldn't figure out how to test this, because the test stalls for input with
`echo test | hg debuguigetpass --config ui.interactive=1`, likely because it
drains stdin before prompting.  The custom input reading with `ui.nontty=1` does
not.

I'm also a bit concerned with all of this encoding/decoding.  The existing code
in the mail module uses `encoding.strfromlocal()`, but the username and password
are ascii encoded/decoded in `mercurial.url.passwordmgr.find_user_password()`
with `pycompat.{str,bytes}url()`.  I'm not sure if this inconsistency could
cause subtle compatability issues.

Differential Revision: https://phab.mercurial-scm.org/D9375

46023:139b334c9392

                    l = self._fin.readline()
                    if not l:
                        raise EOFError
                    return l.rstrip(b'\n')
                else:
                    return getpass.getpass('')
        except EOFError:
            raise error.ResponseExpected()

    def status(self, *msg, **opts):
        '''write status message to output (if ui.quiet is False)

46024:07b0a687c01a

                    l = self._fin.readline()
                    if not l:
                        raise EOFError
                    return l.rstrip(b'\n')
                else:
                    return encoding.strtolocal(getpass.getpass(''))
        except EOFError:
            raise error.ResponseExpected()

    def status(self, *msg, **opts):
        '''write status message to output (if ui.quiet is False)